Dont call hsync() and hflush()

hflush and hsync are only needed for special cases and are overkill here
apache · Oct 14, 2024 · 7ec03c3 · 7ec03c3
1 parent d4384d3
commit 7ec03c3
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopPositionOutputStream.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopPositionOutputStream.java
@@ -50,8 +50,9 @@ public void write(byte[] b, int off, int len) throws IOException {
     wrapped.write(b, off, len);
   }
 
+  @Deprecated
   public void sync() throws IOException {
-    wrapped.hsync();
+    // sync is not necessary for Parquet use cases.
   }
 
   @Override
@@ -61,8 +62,6 @@ public void flush() throws IOException {
 
   @Override
   public void close() throws IOException {
-    try (FSDataOutputStream fdos = wrapped) {
-      fdos.hflush();
-    }
+    wrapped.close();
   }
 }