[core][python] Reject dynamic write-cols optimization changes - #9912
Closed
XiaoHongbo-Hope wants to merge 1 commit into
Closed
XiaoHongbo-Hope wants to merge 1 commit into
XiaoHongbo-Hope wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Enabling
data-evolution.write-cols-optimization.enabledthroughFileStoreTable.copy()changes how normal Data Evolution files encodewriteCols, but the option is not persisted in the table schema. A later reader resolves the file schema without that option and can misinterpret omittedwriteColsas the full schema. With a dedicated BLOB column, a Java-written fixture returned a null BLOB in both Java and PyPaimon instead of the stored bytes.Change
Reject a dynamic override when it changes the effective value of this option in both Java and PyPaimon. Same-value overrides remain allowed. Persisted
ALTER TABLEchanges remain allowed; the option is deliberately not marked immutable.Validation
This prevents new ambiguous files. It does not rewrite files already produced with an unpersisted dynamic override.