HDDS-16072. Implement GetObjectAttributes: ETag, ObjectSize, StorageClass, and ObjectParts count - #10930
Open
Gargi-jais11 wants to merge 5 commits into
Open
HDDS-16072. Implement GetObjectAttributes: ETag, ObjectSize, StorageClass, and ObjectParts count#10930Gargi-jais11 wants to merge 5 commits into
Gargi-jais11 wants to merge 5 commits into
Conversation
Gargi-jais11
marked this pull request as ready for review
August 3, 2026 10:02
Gargi-jais11
requested review from
chungen0126,
ivandika3 and
peterxcli
and removed request for
ivandika3
August 3, 2026 10:03
yandrey321
reviewed
Aug 3, 2026
yandrey321
reviewed
Aug 3, 2026
| OZONE_S3G_FSO_DIRECTORY_CREATION_ENABLED_DEFAULT); | ||
| if (isFsoDirCreationEnabled && | ||
| !key.isFile() && | ||
| !keyPath.endsWith("/")) { |
Contributor
There was a problem hiding this comment.
can key.isFile() return true for the key ends with '/'?
Contributor
Author
There was a problem hiding this comment.
No — for FSO directory keys, isFile() is false. A file key has isFile()==true. the trailing-slash check only gates directory access without /.
Gargi-jais11
requested review from
priyeshkaratha and
yandrey321
and removed request for
yandrey321
August 4, 2026 05:47
Contributor
Author
|
@yandrey321 Please take a look again, I have updated the PR. |
priyeshkaratha
left a comment
Member
There was a problem hiding this comment.
Thanks @Gargi-jais11 for working on this. Please check the provided inline comment.
priyeshkaratha
approved these changes
Aug 11, 2026
Member
There was a problem hiding this comment.
Thanks @Gargi-jais11 for updating the patch. Changes LGTM
chungen0126
approved these changes
Aug 11, 2026
chungen0126
left a comment
Contributor
There was a problem hiding this comment.
Overall, LGTM. Just some nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement the initial GetObjectAttributes support in the S3 Gateway.
PR Changes:
- ETag — object ETag (MD5 or composite hash for multipart objects)
- ObjectSize — object size in bytes
- StorageClass — storage/replication class
- ObjectParts — for multipart objects,
Out of scope:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16072
How was this patch tested?
Added unit test and integration test.
Manually tested: