-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-1871: Include iomanip
at Test(DictionaryEncoding|ConvertColumnReader)
#2175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making a PR, @drupol .
Interestingly, the CI fails consecutively 4 times. Do you have any clues?

Hello, I don't think this is related to my changes... Or is it? Edit: After scrutinizing those logs, I'm quite confident in saying that my changes are not responsible for these breakages. |
I agree with you, @drupol . However, unfortunately, we cannot merge your PR when the CI complains. Could you add an empty commit to this PR in order to retry?
|
fb20db2
to
7ac4928
Compare
@dongjoon-hyun done, you can restart the workflow. Crossing my fingers. |
All good now :) |
Thank you, @drupol . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @wgtmac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @drupol and @dongjoon-hyun!
I think the CI failures are due to unstable connections to download dependencies.
<iomanip>
includesiomanip
at Test(DictionaryEncoding|ConvertColumnReader)
…Reader)` ### What changes were proposed in this pull request? Add missing includes in source files ### Why are the changes needed? To package `orc` in The Linux NixOS distribution. The [PR](NixOS/nixpkgs#395541) has already be merged, it will be available to the public very soon ([PR tracker](https://nixpkgs-tracker.ocfox.me/?pr=395541)). This is [the commit](NixOS/nixpkgs@48ff182) to add `apache-orc` to NixOS in a **reproducible way**. ### How was this patch tested? Compilation is now successfully achieved with the patch. ### Was this patch authored or co-authored using generative AI tooling? Absolutely not. Closes #2175 from drupol/push-yvkkqmxxmzxl. Authored-by: Pol Dellaiera <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit af48c5d) Signed-off-by: Dongjoon Hyun <[email protected]>
…Reader)` ### What changes were proposed in this pull request? Add missing includes in source files ### Why are the changes needed? To package `orc` in The Linux NixOS distribution. The [PR](NixOS/nixpkgs#395541) has already be merged, it will be available to the public very soon ([PR tracker](https://nixpkgs-tracker.ocfox.me/?pr=395541)). This is [the commit](NixOS/nixpkgs@48ff182) to add `apache-orc` to NixOS in a **reproducible way**. ### How was this patch tested? Compilation is now successfully achieved with the patch. ### Was this patch authored or co-authored using generative AI tooling? Absolutely not. Closes #2175 from drupol/push-yvkkqmxxmzxl. Authored-by: Pol Dellaiera <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit af48c5d) Signed-off-by: Dongjoon Hyun <[email protected]>
No I don't. But it's OK, go ahead I don't think I need it. Thank you! |
What changes were proposed in this pull request?
Add missing includes in source files
Why are the changes needed?
To package
orc
in The Linux NixOS distribution. The PR has already be merged, it will be available to the public very soon (PR tracker). This is the commit to addapache-orc
to NixOS in a reproducible way.How was this patch tested?
Compilation is now successfully achieved with the patch.
Was this patch authored or co-authored using generative AI tooling?
Absolutely not.