Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1871: Include iomanip at Test(DictionaryEncoding|ConvertColumnReader) #2175

Closed
wants to merge 1 commit into from

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Apr 2, 2025

What changes were proposed in this pull request?

Add missing includes in source files

Why are the changes needed?

To package orc in The Linux NixOS distribution. The PR has already be merged, it will be available to the public very soon (PR tracker). This is the commit to add apache-orc to NixOS in a reproducible way.

How was this patch tested?

Compilation is now successfully achieved with the patch.

Was this patch authored or co-authored using generative AI tooling?

Absolutely not.

@github-actions github-actions bot added the CPP label Apr 2, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making a PR, @drupol .

Interestingly, the CI fails consecutively 4 times. Do you have any clues?

Screenshot 2025-04-04 at 10 03 39

@drupol
Copy link
Contributor Author

drupol commented Apr 4, 2025

Hello,

I don't think this is related to my changes... Or is it?

Edit: After scrutinizing those logs, I'm quite confident in saying that my changes are not responsible for these breakages.

@dongjoon-hyun
Copy link
Member

I agree with you, @drupol . However, unfortunately, we cannot merge your PR when the CI complains.

Could you add an empty commit to this PR in order to retry?

git commit --allow-empty -m "Retry"

@drupol drupol force-pushed the push-yvkkqmxxmzxl branch from fb20db2 to 7ac4928 Compare April 4, 2025 08:16
@drupol
Copy link
Contributor Author

drupol commented Apr 4, 2025

@dongjoon-hyun done, you can restart the workflow. Crossing my fingers.

@drupol
Copy link
Contributor Author

drupol commented Apr 4, 2025

All good now :)

@dongjoon-hyun
Copy link
Member

Thank you, @drupol .

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @wgtmac

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @drupol and @dongjoon-hyun!

I think the CI failures are due to unstable connections to download dependencies.

@dongjoon-hyun dongjoon-hyun changed the title fix: add missing <iomanip> includes ORC-1871: Include iomanip at Test(DictionaryEncoding|ConvertColumnReader) Apr 8, 2025
@dongjoon-hyun dongjoon-hyun added this to the 2.0.5 milestone Apr 8, 2025
dongjoon-hyun pushed a commit that referenced this pull request Apr 8, 2025
…Reader)`

### What changes were proposed in this pull request?

Add missing includes in source files

### Why are the changes needed?

To package `orc` in The Linux NixOS distribution. The [PR](NixOS/nixpkgs#395541) has already be merged, it will be available to the public very soon ([PR tracker](https://nixpkgs-tracker.ocfox.me/?pr=395541)). This is [the commit](NixOS/nixpkgs@48ff182) to add `apache-orc` to NixOS in a **reproducible way**.

### How was this patch tested?

Compilation is now successfully achieved with the patch.

### Was this patch authored or co-authored using generative AI tooling?

Absolutely not.

Closes #2175 from drupol/push-yvkkqmxxmzxl.

Authored-by: Pol Dellaiera <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit af48c5d)
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun pushed a commit that referenced this pull request Apr 8, 2025
…Reader)`

### What changes were proposed in this pull request?

Add missing includes in source files

### Why are the changes needed?

To package `orc` in The Linux NixOS distribution. The [PR](NixOS/nixpkgs#395541) has already be merged, it will be available to the public very soon ([PR tracker](https://nixpkgs-tracker.ocfox.me/?pr=395541)). This is [the commit](NixOS/nixpkgs@48ff182) to add `apache-orc` to NixOS in a **reproducible way**.

### How was this patch tested?

Compilation is now successfully achieved with the patch.

### Was this patch authored or co-authored using generative AI tooling?

Absolutely not.

Closes #2175 from drupol/push-yvkkqmxxmzxl.

Authored-by: Pol Dellaiera <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit af48c5d)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member

Thank you, @drupol and @wgtmac .
Merged to main/2.1/2.0.

@dongjoon-hyun
Copy link
Member

Do you have Apache JIRA ID, @drupol ?

I created ORC-1871 for your PR. If you have ID, I can add you to the Apache ORC contributor group and assign ORC-1871 to you.

@drupol
Copy link
Contributor Author

drupol commented Apr 8, 2025

Do you have Apache JIRA ID, @drupol ?

I created ORC-1871 for your PR. If you have ID, I can add you to the Apache ORC contributor group and assign ORC-1871 to you.

No I don't. But it's OK, go ahead I don't think I need it.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants