fix(ci): use NuGet login action instead of manual login nuget#7903
Merged
Conversation
dosubot
Bot
added
size:XS
Fatorin
changed the title
Contributor
Author
|
Update: ASF allow list now supports NuGet/login action, so I changed the implementation to use the official action instead of the previous manual authentication flow. |
erickguan
reviewed
Jul 12, 2026
| | python3 -c 'import json, sys; print(json.load(sys.stdin)["apiKey"])')" | ||
| echo "::add-mask::${api_key}" | ||
| echo "NUGET_API_KEY=${api_key}" >> "${GITHUB_OUTPUT}" | ||
| uses: NuGet/login@8d196754b4036150537f80ac539e15c2f1028841 |
Member
There was a problem hiding this comment.
I recommend adding a version like other actions.
Contributor
Author
There was a problem hiding this comment.
I tried using NuGet/login@v1.2.0, but it failed the ASF Allowlist Check.
I pinned it to the commit SHA and added the # v1.2.0 version comment in the latest commit.
erickguan
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7899
Rationale for this change
ASF allow list now supports the NuGet/login action, so we can use the official action instead of the previous manual NuGet authentication flow.
This simplifies the workflow and provides a more maintainable approach for NuGet trusted publishing.
What changes are included in this PR?
NuGet/loginaction.Are there any user-facing changes?
None.
AI Usage Statement
Used GPT-5.5-mini to help write the PR description and verify the content.