Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC-5485: Conditional Reader #5485

Merged
merged 5 commits into from
Jan 2, 2025
Merged

RFC-5485: Conditional Reader #5485

merged 5 commits into from
Jan 2, 2025

Conversation

meteorgan
Copy link
Contributor

Which issue does this PR close?

Part of #5426.

Rationale for this change

Add if_match, if_none_match, if_modified_since and if_unmodified_since options to reader_with API to support conditional reader based on etag and/or modification time.

What changes are included in this PR?

a new RFC

Are there any user-facing changes?

new options for reader_with API

@meteorgan meteorgan mentioned this pull request Dec 31, 2024
Open
9 tasks
@meteorgan
Copy link
Contributor Author

Hi, @XmchxUp I've left the if_match and if_none_match options for you to handle. but I'm not sure if you have write access to this PR.

@meteorgan meteorgan changed the title RFC: reader_options RFC: options_for_reader Dec 31, 2024
@meteorgan meteorgan changed the title RFC: options_for_reader RFC-5485: options_for_reader Dec 31, 2024
@meteorgan meteorgan changed the title RFC-5485: options_for_reader RFC-5485: options_for_reader_with Dec 31, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Dec 31, 2024

Hi, @XmchxUp I've left the if_match and if_none_match options for you to handle. but I'm not sure if you have write access to this PR.

I believe @XmchxUp can assist with the implementation; we can complete the RFC first.

@meteorgan meteorgan changed the title RFC-5485: options_for_reader_with RFC-5485: conditional_reader Dec 31, 2024
@meteorgan meteorgan marked this pull request as ready for review December 31, 2024 13:45
@Xuanwo Xuanwo changed the title RFC-5485: conditional_reader RFC-5485: Conditional Reader Dec 31, 2024
Xuanwo
Xuanwo reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, thanks!

core/src/docs/rfcs/5485_conditional_reader.md Outdated Show resolved Hide resolved
@XmchxUp
Copy link
Contributor

XmchxUp commented Jan 1, 2025

Thank you @meteorgan.

I believe @XmchxUp can assist with the implementation; we can complete the RFC first.

Of course I'm willing to implement if_match, if_none_match.

Xuanwo
Xuanwo approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's move!

@Xuanwo Xuanwo merged commit 0b8b1c5 into apache:main Jan 2, 2025
228 checks passed
@meteorgan meteorgan deleted the reader_options_rfc branch January 2, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XmchxUp XmchxUp XmchxUp left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meteorgan @Xuanwo @XmchxUp