feat(core): abstract HttpFetch trait for raw http client #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Oct 16, 2024
Xuanwo
reviewed
Oct 16, 2024
core/src/raw/http_util/client.rs
Outdated
| pub(crate) static GLOBAL_REQWEST_CLIENT: Lazy<reqwest::Client> = Lazy::new(reqwest::Client::new); | ||
|
|
||
| /// HttpFetcher is a type erased [`HttpFetch`]. | ||
| pub type HttpFetcher = Box<dyn HttpFetchDyn>; |
There was a problem hiding this comment.
We can use Arc<dyn HttpFetchDyn> here to eliminate the need for an extra Box.
| } | ||
| } | ||
|
|
||
| pub trait HttpFetch: Send + Sync + Unpin + 'static { |
There was a problem hiding this comment.
Please add comments to this trait. This trait is exposed to users, and we expect that users should never interact with HttpFetchDyn.
core/src/raw/http_util/client.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl<T: HttpFetchDyn + ?Sized> HttpFetch for Box<T> { |
| @@ -25,6 +25,10 @@ | |||
| mod client; | |||
| pub use client::HttpClient; | |||
|
|
|||
| /// temporary client used by several features | |||
| #[allow(unused_imports)] | |||
| pub(crate) use client::GLOBAL_REQWEST_CLIENT; | |||
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4471
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?