Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codspeed for benchmark #4993

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

dqhl76
Copy link
Member

@dqhl76 dqhl76 commented Aug 10, 2024

Which issue does this PR close?

Closes #4937 .

Rationale for this change

Trying to add a benchmark workflow to track and compare performance

What changes are included in this PR?

A new workflow that runs on every PR and the default main branch.
The criterion dependency is changed to codspeed-criterion-compat.
This should not affect cargo bench

Are there any user-facing changes?

No


Wait for approval from infra team https://issues.apache.org/jira/projects/INFRA/issues/INFRA-26030?filter=allissues

uses: CodSpeedHQ/action@v3
with:
run: cargo codspeed run
token: ${{ secrets.CODSPEED_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please load from 1password.

Copy link
Member Author

@dqhl76 dqhl76 Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will use 1password after I get the token. Thanks for the review.

@Xuanwo
Copy link
Member

Xuanwo commented Aug 10, 2024

Hi, @adriencaccia, OpenDAL has a benchmark suite that can run tests over different services based on the environment. Does Codspeed support our case? For example, running Cargo Codspeed multiple times can display their performance in groups based on service.

@dqhl76
Copy link
Member Author

dqhl76 commented Aug 15, 2024

image

@adriencaccia
Copy link

Hi, @adriencaccia, OpenDAL has a benchmark suite that can run tests over different services based on the environment. Does Codspeed support our case? For example, running Cargo Codspeed multiple times can display their performance in groups based on service.

Hey, at the moment there is no support for grouping benchmarks.
What I would recommend in the meantime, if relevant, is to manually change the name of the benchmarks depending on the service.
For example, for a benchmark myBench in the codebase, you could make its name depending on the service, so that multiple benchmarks are tracked on CodSpeed: service1-myBench, service2-myBench, service3-myBench...

@Xuanwo
Copy link
Member

Xuanwo commented Aug 29, 2024

Hi, @adriencaccia, there are some concerns from the ASF INFRA, do you have comments?

image

@adriencaccia
Copy link

Hi, @adriencaccia, there are some concerns from the ASF INFRA, do you have comments?

image

Hey, I just answered in apache/arrow-rs#6150 (comment) 😉

@Xuanwo
Copy link
Member

Xuanwo commented Aug 29, 2024

Hey, I just answered in apache/arrow-rs#6150 (comment) 😉

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new feature: Add CodSpeed for benchmark
3 participants