feat(integrations/cloudfilter): introduce behavior tests #4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ho-229
force-pushed
the
cf_behavior_tests
branch
from
8a3b935
to
2b68b95
Compare
ho-229
force-pushed
the
cf_behavior_tests
branch
from
e6c9959
to
35b7027
Compare
ho-229
force-pushed
the
cf_behavior_tests
branch
from
ebdb6ae
to
2454c3c
Compare
Xuanwo
reviewed
Aug 11, 2024
| @@ -270,6 +286,20 @@ def generate_bin_cases( | |||
|
|
|||
| return cases | |||
|
|
|||
| def generate_integration_cases( | |||
There was a problem hiding this comment.
Maybe we don't need to touch here if cloudfilter only support fs now?
| connect-token: ${{ secrets.OP_CONNECT_TOKEN }} | ||
|
|
||
| - name: Test Integration CloudFilter | ||
| uses: ./.github/actions/test_behavior_integration_cloudfilter |
There was a problem hiding this comment.
We can test directly here without altering the entire integration test system if Cloudflitler only supports fs.
|
Fixed cc @Xuanwo |
Xuanwo
reviewed
Aug 11, 2024
There was a problem hiding this comment.
Maybe we can also remove those changes.
.github/workflows/test_behavior.yml
Outdated
| @@ -145,3 +145,17 @@ jobs: | |||
| with: | |||
| os: ${{ matrix.os }} | |||
| cases: ${{ toJson(matrix.cases) }} | |||
|
|
|||
| test_integration_cloudfilter: | |||
| name: Behavior Test Integration CloudFilter | ||
|
|
||
| on: | ||
| workflow_call: |
There was a problem hiding this comment.
We can use on pull_request instead.
Xuanwo
reviewed
Aug 11, 2024
|
cc @Xuanwo , PTAL |
Xuanwo
reviewed
Aug 13, 2024
Comment on lines
47
to
55
| # TODO: 1password is only supported on linux | ||
| # | ||
| # Waiting for https://github.com/1Password/load-secrets-action/issues/46 | ||
| - name: Setup 1Password Connect | ||
| if: runner.os == 'Linux' | ||
| uses: 1password/load-secrets-action/configure@v1 | ||
| with: | ||
| connect-host: ${{ secrets.OP_CONNECT_HOST }} | ||
| connect-token: ${{ secrets.OP_CONNECT_TOKEN }} |
| with: | ||
| need-protoc: true | ||
| need-rocksdb: true | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} |
|
Fixed @Xuanwo |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
integration/cloudfilter.cloud-filterto0.0.5.