Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release/go): add Go Binding release #4945

Closed
wants to merge 1 commit into from
Closed

Conversation

yuchanns
Copy link
Member

Part of #4892.

@yuchanns yuchanns force-pushed the main branch 3 times, most recently from 2d232ae to 850392f Compare August 1, 2024 11:27
@Xuanwo
Copy link
Member

Xuanwo commented Aug 1, 2024

Problem Hitted: The ASF doesn't allow us to create Fine-grained personal access tokens. And Personal access token (classic) requires the Full control of private repositories permissions.

Although I trust all OpenDAL PMC members, I still feel uncomfortable generating and sharing such a token in 1Password.

Do we have other choices?

@yuchanns
Copy link
Member Author

yuchanns commented Aug 1, 2024

Can we use Github Secrets instead?

@Xuanwo
Copy link
Member

Xuanwo commented Aug 1, 2024

Can we use Github Secrets instead?

No differences for that.


How about use schedule with cron in opendal-go-services instead? We can pull opendal tags every five mintues, and build if new tags happend.

@yuchanns
Copy link
Member Author

yuchanns commented Aug 1, 2024

I'll take a try.

@yuchanns yuchanns marked this pull request as draft August 1, 2024 11:38
@Xuanwo
Copy link
Member

Xuanwo commented Aug 1, 2024

I'll take a try.

Sorry for the inconvenience and thank you for your patience.

@yuchanns
Copy link
Member Author

yuchanns commented Aug 2, 2024

The part about releasing services has been moved to apache/opendal-go-services#9.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I believe this action is unnecessary. Tags in OpenDAL can be created directly by the release manager. We just need to update the release document on how to release the Go binding.

@yuchanns
Copy link
Member Author

yuchanns commented Aug 2, 2024

Alright. I'm just not familiar with the release process of Apache products. I'll close this PR.

We just need to update the release document on how to release the Go binding.

It's your control now. :)

@yuchanns yuchanns closed this Aug 2, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Aug 2, 2024

Alright. I'm just not familiar with the release process of Apache products. I'll close this PR.

Releasing is the most important thing of the ASF. Are you interested in becoming our next release manager who will release first version of go binding? I'm willing to provide help you need.

@yuchanns
Copy link
Member Author

yuchanns commented Aug 2, 2024

Sorry, but I'm not interested in release. I think it is better to have you leading the version release.

I would like to answer any questions if you encounter issues in release go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants