feat(services/monoiofs): impl read and write, add behavior test #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NKID00
requested review from
messense,
Zheaoli,
suyanhanx and
tisonkun
as code owners
|
There seems to be an unknown bug (probably some race condition) that causes monoio runtime to occasionally fail to initialize (seems only affect Node.js binding). I'll take a deeper look. |
|
Thanks for your PR! I will review it later this week. |
Xuanwo
reviewed
Aug 2, 2024
This was referenced Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4552.
This PR implements basic read and write operations for
monoiofs. The implementation differs fromcompfsin that file opened with monoio is stored within the worker thread because it is non-Send and non-Sync. Read and write operations send buffers to worker thread and receive results instead of send futures.This PR also introduces behavior tests for
monoiofs. Implementations of stat and delete are borrowed fromFsBackendto satisfy requirements of behavior tests. They are not implemented natively because monoio's support for file metadata is not released yet and file deletion is currently not implemented.