feat(ovfs): supplementary opendal related functions #4825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjregee
changed the title
|
@Xuanwo, it's ready for review now. |
This was referenced Aug 2, 2024
Xuanwo
reviewed
Aug 5, 2024
| struct FileKey(usize); | ||
|
|
||
| /// OpenedFile represents file that opened in memory. | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Hi, from my perspective, adding dead_code is not ideal. If they are useful, please consider using pub use to include them.
| /// Filesystem is a filesystem implementation with opendal backend, | ||
| /// and will decode and process messages from VMs. | ||
| pub struct Filesystem {} | ||
| #[allow(dead_code)] | ||
| pub struct Filesystem { |
There was a problem hiding this comment.
Maybe we can export Filesystem out?
|
Hi, @Xuanwo. I think this PR may be too old and the updated code may introduce a lot of dead code because there is no clear goal for this PR. This may be a bit strange, so I will resubmit a PR tomorrow. |
Thanks and sorry for reviewing it so late. |
|
This won't be a problem. 💌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.