-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): Enable supabase integration tests #2190
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Sure, I will have a look at it. |
Seems supabase does not support special characters In
Any ideas on this test? |
Supabase said:
Maybe we just need to make sure the path has been percent encoded? |
Following the first line is what we are using in our behavior tests. As I tested, the third line which removed '#', '%' and '^' works out fine. let path = format!("{} !@#$%^&()_+-=;',.txt", uuid::Uuid::new_v4());
// remove # % and ^
let path = format!("{} !@$&()_+-=;',.txt", uuid::Uuid::new_v4()); In the Maybe we should remove these three characters, at least from the amazon's spec we should avoid these three. |
More like a bug: supabase/storage#133 As Supabase Storage is an open-source project, I would rather collaborate with the upstream team than find workarounds. |
Before this bug addressed, you can add code like the following for // Ignore test for supabase until https://github.com/apache/incubator-opendal/issues/2194 addressed.
if op.info().scheme() == Scheme::Supabase {
warn!("ignore test for supabase unitl https://github.com/apache/incubator-opendal/issues/2194 addressed")
return Ok(());
} |
Hi, @suyanhanx, I think we can merge this PR first and create a tracking issue for supabase's not passed test cases. |
It‘s ok to me. Just merge after the conflict is resolved. |
Tracked at #2199 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This PR will enable supabase integration tests
Hi, @Ji-Xinyou, many write related tests failed, would like to take a look?