drivers/mtd: Make compile time check for sane mtd isbad/markbad configuration#19145
Open
jlaitine wants to merge 1 commit into
Open
drivers/mtd: Make compile time check for sane mtd isbad/markbad configuration#19145jlaitine wants to merge 1 commit into
jlaitine wants to merge 1 commit into
Conversation
github-actions
Bot
added
Area: Drivers
| @@ -52,7 +52,7 @@ config FTL_READAHEAD | |||
|
|
|||
| config FTL_BBM | |||
| bool "Enable bad block management in the FTL layer" | |||
Contributor
There was a problem hiding this comment.
remove the prompt string
jlaitine
force-pushed
the
fix_ftl_bbm_configuration
branch
from
a212414 to
d934816
Compare
jlaitine
requested review from
Donny9,
jerpelea,
michallenc,
pkarashchenko and
yamt
as code owners
…guration This removes the DEBUGASSERT in ftl_initialize_by_path. Instead, check compile time that FTL is enabled in case some of the drivers implement the isbad and markbad functions. Also select the FTL_BBM for those drivers as they require it. Signed-off-by: Jukka Laitinen <jukka.laitinen@tii.ae>
jlaitine
force-pushed
the
fix_ftl_bbm_configuration
branch
from
d934816 to
71ef4e2
Compare
github-actions
Bot
added
the
Arch: arm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the DEBUGASSERT in ftl_initialize_by_path. Instead, check compile time that FTL is enabled in case some of the drivers implement the isbad and markbad functions.
Also select the FTL_BBM for those drivers as they require it.
Impact
This checks the validity of bad-block management configuration at build time; the compilation fails
if the mtd driver implements bad block management, but the configuration doesn't enable the FTL_BBM
Testing
Tested by compiling this PR in CI