Skip to content

Conversation

@W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Jan 30, 2026

sigdelset is used in up_enable_irq: sigdelset(&act.sa_mask, SIGSTOP);

Note: Please adhere to Contributing Guidelines.

Summary

arch/sim: Add sigdelset to nuttx-names.in

Impact

none

Testing

citest

sigdelset is used in up_enable_irq: sigdelset(&act.sa_mask, SIGSTOP);

Signed-off-by: wangmingrong1 <[email protected]>
@github-actions github-actions bot added Arch: simulator Issues related to the SIMulator Size: XS The size of the change in this PR is very small labels Jan 30, 2026
Copy link
Contributor

@acassis acassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Jan 30, 2026

@W-M-R please update the Documentation: https://nuttx.apache.org/docs/latest/reference/user/07_signals.html

@acassis this patch doesn't add/remove nuttx signal api, why do you request @W-M-R update document?

@acassis
Copy link
Contributor

acassis commented Jan 30, 2026

@W-M-R please update the Documentation: https://nuttx.apache.org/docs/latest/reference/user/07_signals.html

@acassis this patch doesn't add/remove nuttx signal api, why do you request @W-M-R update document.

@xiaoxiang781216 the idea is to keep the signal documentation updated and since he is working on signal, this is the right moment to do it:

image

@xiaoxiang781216
Copy link
Contributor

@W-M-R please update the Documentation: https://nuttx.apache.org/docs/latest/reference/user/07_signals.html

@acassis this patch doesn't add/remove nuttx signal api, why do you request @W-M-R update document.

@xiaoxiang781216 the idea is to keep the signal documentation updated and since he is working on signal, this is the right moment to do it:

image

here is https://nuttx.apache.org/docs/latest/reference/user/07_signals.html#c.sigdelset

@acassis
Copy link
Contributor

acassis commented Jan 30, 2026

@W-M-R please update the Documentation: https://nuttx.apache.org/docs/latest/reference/user/07_signals.html

@acassis this patch doesn't add/remove nuttx signal api, why do you request @W-M-R update document.

@xiaoxiang781216 the idea is to keep the signal documentation updated and since he is working on signal, this is the right moment to do it:
image

here is https://nuttx.apache.org/docs/latest/reference/user/07_signals.html#c.sigdelset

But and the remaining signals that should be in that table?

CONFIG_SIG_SIGPIPE_ACTION
CONFIG_SIG_SIGPROF_ACTION
CONFIG_SIG_SIGURG_ACTION
etc

Please take a look here: sched/signal/sig_default.c

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Jan 30, 2026

@W-M-R please update the Documentation: https://nuttx.apache.org/docs/latest/reference/user/07_signals.html

@acassis this patch doesn't add/remove nuttx signal api, why do you request @W-M-R update document.

@xiaoxiang781216 the idea is to keep the signal documentation updated and since he is working on signal, this is the right moment to do it:
image

here is https://nuttx.apache.org/docs/latest/reference/user/07_signals.html#c.sigdelset

But and the remaining signals that should be in that table?

CONFIG_SIG_SIGPIPE_ACTION CONFIG_SIG_SIGPROF_ACTION CONFIG_SIG_SIGURG_ACTION etc

Please take a look here: sched/signal/sig_default.c

This pr doesn't touch sig_default.c, so the update shouldn't belong to this pr. @acassis if you find something miss, please provide a patch to fix it, it doesn't make sense to ask contributor to update the doc which doesn't make related modification.

@acassis
Copy link
Contributor

acassis commented Jan 30, 2026

@W-M-R please update the Documentation: https://nuttx.apache.org/docs/latest/reference/user/07_signals.html

@acassis this patch doesn't add/remove nuttx signal api, why do you request @W-M-R update document.

@xiaoxiang781216 the idea is to keep the signal documentation updated and since he is working on signal, this is the right moment to do it:
image

here is https://nuttx.apache.org/docs/latest/reference/user/07_signals.html#c.sigdelset

But and the remaining signals that should be in that table?
CONFIG_SIG_SIGPIPE_ACTION CONFIG_SIG_SIGPROF_ACTION CONFIG_SIG_SIGURG_ACTION etc
Please take a look here: sched/signal/sig_default.c

This pr doesn't touch sig_default.c, so the update shouldn't belong to this pr. @acassis if you find something miss, please provide a patch to fix it, it doesn't make sense to ask contributor to update the doc which doesn't make related modification.

Ok, yes I can dismiss the Change Request, but the point is: our Documentation is outdated, so everything someone is working is some relative feature that needs to be improved, we need to use request it. Even the file sig_default.c is not modified, the person modifying signals is the authority, they know more about signals than someone working on other features.

@acassis
Copy link
Contributor

acassis commented Jan 30, 2026

@W-M-R so I will let it for you: can you update the signals Documentation or will let us continue with outdated Documentation? Do you want to improve our Documentation?

@xiaoxiang781216 xiaoxiang781216 merged commit 28026af into apache:master Jan 31, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: simulator Issues related to the SIMulator Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants