-
Notifications
You must be signed in to change notification settings - Fork 1.5k
arch/sim: Add sigdelset to nuttx-names.in #18277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sigdelset is used in up_enable_irq: sigdelset(&act.sa_mask, SIGSTOP); Signed-off-by: wangmingrong1 <[email protected]>
acassis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@W-M-R please update the Documentation: https://nuttx.apache.org/docs/latest/reference/user/07_signals.html
@acassis this patch doesn't add/remove nuttx signal api, why do you request @W-M-R update document? |
@xiaoxiang781216 the idea is to keep the signal documentation updated and since he is working on signal, this is the right moment to do it:
|
here is https://nuttx.apache.org/docs/latest/reference/user/07_signals.html#c.sigdelset |
But and the remaining signals that should be in that table? CONFIG_SIG_SIGPIPE_ACTION Please take a look here: sched/signal/sig_default.c |
This pr doesn't touch sig_default.c, so the update shouldn't belong to this pr. @acassis if you find something miss, please provide a patch to fix it, it doesn't make sense to ask contributor to update the doc which doesn't make related modification. |
Ok, yes I can dismiss the Change Request, but the point is: our Documentation is outdated, so everything someone is working is some relative feature that needs to be improved, we need to use request it. Even the file sig_default.c is not modified, the person modifying signals is the authority, they know more about signals than someone working on other features. |
|
@W-M-R so I will let it for you: can you update the signals Documentation or will let us continue with outdated Documentation? Do you want to improve our Documentation? |


sigdelset is used in up_enable_irq: sigdelset(&act.sa_mask, SIGSTOP);
Note: Please adhere to Contributing Guidelines.
Summary
arch/sim: Add sigdelset to nuttx-names.in
Impact
none
Testing
citest