arm64/SMP: Fix FPU and exception handling for ARM64 #13695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: arm64
|
@GUIDINGLI the adaptation with #13520 is almost done. Flat mode nsh and nsh_smp both work, knsh doesn't work yet due to how SP_EL0 handling was changed. Can you please take a look that the SMP issue you mentioned is OK with these changes? I'll fix the kernel mode issue on Monday. |
Signed-off-by: ligd <[email protected]>
Signed-off-by: ligd <[email protected]>
Signed-off-by: lipengfei28 <[email protected]>
As the handling of sp_el0 was moved from the context switch routine to exception entry/exit, we must set sp_el0 explicitly when the user process is first started.
pussuw
force-pushed
the
arm64_smp_irqstack_fix
branch
from
76cae8a
to
f387b02
Compare
|
SP_EL0 handling is now also fixed. Tested with: |
pussuw
commented
Oct 1, 2024
| sizeof(struct arm64_cpu_fpu_context)); | ||
| g_cpu_fpu_ctx[cpu].idle_thread = tcb; | ||
|
|
||
| tcb->xcp.fpu_regs = (uint64_t *)&g_idle_thread_fpu[cpu]; |
There was a problem hiding this comment.
What about:
- tcb->xcp.fpu_regs
- tcb->xcp.fpu_saved_regs
what should we do with those ?
xiaoxiang781216
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix FPU and exception handling for ARM64 by:
This is a continuation of: #13520
@GUIDINGLI and @lipengfei28 Did the initial patches, which are adapted for CONFIG_BUILD_KERNEL / CONFIG_LIB_SYSCALL, which were implemented by me. The goal is to merge this work without breaking either one.
Impact
Impact is on ARM64 platform only. The impacted parts are the exception and ISR handling.
Testing
qemu-armv8a:nsh
qemu-armv8a:nsh_smp
qemu-armv8a:knsh