tools/btdecode.sh: make grep overridable #13650
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script seems to assume GNU grep, which is not commonly available as "grep" on some platforms. For examples, it's more common to have it named "ggrep" on BSD-based systems including macOS. Ideally, I suppose we should avoid GNU dependencies like this in general. But I'm not motivated enough to rewrite this script in a portable way today. cf. https://www.gnu.org/software/grep/manual/grep.html#grep-Programs-1
github-actions
bot
added
Area: Tooling
Size: XS
acassis
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This script seems to assume GNU grep, which is not commonly available as "grep" on some platforms. For examples, it's more common to have it named "ggrep" on BSD-based systems including macOS.
Ideally, I suppose we should avoid GNU dependencies like this in general. But I'm not motivated enough to rewrite this script in a portable way today.
cf. https://www.gnu.org/software/grep/manual/grep.html#grep-Programs-1
Impact
Testing
lightly tested on macOS with homebrew-installed GNU grep