Master

[TOMASHEVSKIYIVAN]

Summary

fixed usbconsole on weact STM32H743VI

Impact

new debug experience for users

Testing

[TOMASHEVSKIYIVAN]

usbconsole weact STM32H743VI fix

[nuttxpr]

[Experimental Bot, please feedback here]

Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.

No, this PR does not fully meet the NuttX requirements. Here's why:

• Insufficient Summary: The summary is too brief.
  • What was the problem with usbconsole?
  • How was it fixed? What code was changed?
• Impact: While a "new debug experience" is mentioned, it's not clear how it impacts:
  • Users: Will they need to do anything differently?
  • Build: Are there any configuration changes needed?
  • Hardware: Are there specific USB requirements now?
  • Documentation: Is documentation updated to reflect the fix?
• Missing Testing Details:
  • No build host information provided.
  • No "before" and "after" testing logs.

To improve this PR:

1. Expand the Summary: Provide specific details about the bug and the fix.
2. Complete the Impact Section: Address all the points mentioned above.
3. Add Testing Details: Specify your build host environment and include the requested logs.

[acassis]

Hi @buzdalin thank you for your contribution. Please fix my comments.

You can read the documentation explaining how to fix and push the modifications to this PR:
https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request

[acassis]

Hi @TOMASHEVSKIYIVAN, thanks for fixing the comments.

Please don't use Merge, use git rebase, as explained in the documentation. Also squash the PRs as explained in the link I sent to you early

[acassis]

The CI is failing because this small issue:

../nuttx/tools/checkpatch.sh -u -m -g 203944b7240d9c0a5deeb71a925688449024ced2..HEAD
Error: .../nuttx/boards/arm/stm32h7/weact-stm32h743/include/board.h:346:0: error: Wrong column position or missing blank line before comment
Error: Process completed with exit code 1.

[TOMASHEVSKIYIVAN]

@acassis, please excuse me. I'm kinda newbie in git and github

[TOMASHEVSKIYIVAN]

@acassis guess i created new pr...

[acassis]

@acassis guess i created new pr...

Seems better, but you forgot to fix:

Error: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/stm32h7/weact-stm32h743/include/board.h:346:0: error: Wrong column position or missing blank line before comment

You can test it before push the commit, this way:

./tools/checkpatch.sh -g HEAD~...HEAD

[acassis]

@acassis, please excuse me. I'm kinda newbie in git and github

Don't worry! You are learning by doing!

[acassis]

@TOMASHEVSKIYIVAN now it is passing in the CI, but you forgot to squash the PR :-)