File reference count bug fix

[Zhangshoukui]

Summary

bug fix

1. Should call fs_putfilep put fs reference when call files_fget complete
2. FS_RAMMAP depends on FS_REFCOUNT and remove useless macro

Impact

all CONFIG_FS_REFCOUNT and CONFIG_DUMP_ON_EXIT config, A reference count exception exists. Procedure

Testing

open CONFIG_FS_REFCOUNT and CONFIG_DUMP_ON_EXIT，call files_dumplist

[nuttxpr]

[Experimental Bot, please feedback here]

The provided PR description is missing crucial information and does not meet the NuttX requirements.

Here's a breakdown:

Missing Information:

• Insufficient Summary:
  • Why: While it mentions a bug fix, it lacks a clear explanation of the problem the fix addresses. What were the symptoms of the bug?
  • What: The description of the functional change is too vague. Be specific about the code files modified and the logic adjusted.
  • How: The explanation of how the change works is insufficient. Provide a concise, technical overview of the implemented solution.
  • Links: No related NuttX issues or pull requests are linked. This context is essential for reviewers.
• Incomplete Impact Assessment:
  • Feature Impact: The description only states "all CONFIG_FS_REFCOUNT and CONFIG_DUMP_ON_EXIT config," which isn't informative enough. Clearly state if this is a bug fix only or introduces any functional changes.
  • User Impact: Does this fix change any user-facing behavior? Be explicit.
  • Build Impact: While it mentions a "Procedure," it's unclear what this means. Specify any build system changes required.
  • Other Impacts: The remaining impact categories are completely unaddressed.
• Insufficient Testing:
  • Environment Details: The testing environment description is too generic. Provide specific details about:
    • Build Host OS, CPU architecture, compiler version
    • Target architecture (simulator, specific hardware), board name, NuttX configuration used
  • Missing Logs: "your testing logs here" is unhelpful. Include actual relevant log snippets demonstrating:
    • The problem before the fix
    • The successful outcome after the fix

Recommendations to Meet Requirements:

1. Expand the Summary:

   • Clearly articulate the bug's symptoms and impact.
   • Provide specific details about the code being changed.
   • Explain the solution's technical implementation concisely.
   • Link any relevant NuttX issues or pull requests.

2. Complete the Impact Assessment:

   • Address all impact categories with "YES" or "NO."
   • Provide detailed explanations for each "YES," clearly outlining the changes and their implications.

3. Provide Thorough Testing Information:

   • Specify the exact build host and target environments.
   • Include real log snippets that demonstrate the bug and the successful fix.

By addressing these points, you will create a PR that is informative, meets NuttX's standards, and facilitates efficient review.