NIFI-15963 Remove ErrorBanner in favor of Banner

nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/ui/common/context-error-banner/context-error-banner.component.html

@@ -17,4 +17,4 @@
   ~ under the License.
   -->
 
-<error-banner [messages]="messages$ | async" (dismiss)="dismiss()"></error-banner>
+<banner [messages]="messages$ | async" (dismiss)="dismiss()"></banner>

nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/ui/common/context-error-banner/context-error-banner.component.ts

@@ -25,12 +25,12 @@ import { clearBannerErrors } from '../../../state/error/error.actions';
 import { Observable } from 'rxjs';
 import { selectBannerErrors } from '../../../state/error/error.selectors';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
-import { ErrorBanner } from '@nifi/shared';
+import { Banner } from '@nifi/shared';
 import { ErrorContextKey } from '../../../state/error';
 
 @Component({
     selector: 'context-error-banner',
-    imports: [CommonModule, ErrorBanner],
+    imports: [CommonModule, Banner],
     templateUrl: './context-error-banner.component.html',
     styleUrl: './context-error-banner.component.scss'
 })

nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/access-policies/ui/component-access-policies/component-access-policies.module.ts

@@ -29,7 +29,7 @@ import { ComponentAccessPoliciesRoutingModule } from './component-access-policie
 import { RouterModule } from '@angular/router';
 import { PolicyTable } from '../common/policy-table/policy-table.component';
 import { MatButtonModule } from '@angular/material/button';
-import { ComponentContext, NifiTooltipDirective, ErrorBanner } from '@nifi/shared';
+import { ComponentContext, NifiTooltipDirective } from '@nifi/shared';
 import { ContextErrorBanner } from '../../../../ui/common/context-error-banner/context-error-banner.component';
 
 @NgModule({
@@ -50,7 +50,6 @@ import { ContextErrorBanner } from '../../../../ui/common/context-error-banner/c
         NifiTooltipDirective,
         PolicyTable,
         MatButtonModule,
-        ErrorBanner,
         ComponentContext,
         ContextErrorBanner
     ]

nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/access-policies/ui/global-access-policies/global-access-policies.module.ts

@@ -26,7 +26,7 @@ import { MatFormFieldModule } from '@angular/material/form-field';
 import { ReactiveFormsModule } from '@angular/forms';
 import { MatSelectModule } from '@angular/material/select';
 import { GlobalAccessPoliciesRoutingModule } from './global-access-policies-routing.module';
-import { NifiTooltipDirective, ErrorBanner } from '@nifi/shared';
+import { NifiTooltipDirective } from '@nifi/shared';
 import { PolicyTable } from '../common/policy-table/policy-table.component';
 import { MatButtonModule } from '@angular/material/button';
 import { ContextErrorBanner } from '../../../../ui/common/context-error-banner/context-error-banner.component';
@@ -48,7 +48,6 @@ import { ContextErrorBanner } from '../../../../ui/common/context-error-banner/c
         NifiTooltipDirective,
         PolicyTable,
         MatButtonModule,
-        ErrorBanner,
         ContextErrorBanner
     ]
 })

nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/cluster/feature/cluster.module.ts

@@ -27,7 +27,6 @@ import { ClusterRoutingModule } from './cluster-routing.module';
 import { RouterModule } from '@angular/router';
 import { MatTabsModule } from '@angular/material/tabs';
 import { MatIconButton } from '@angular/material/button';
-import { ErrorBanner } from '@nifi/shared';
 import { BannerText } from '../../../ui/common/banner-text/banner-text.component';
 import { ContextErrorBanner } from '../../../ui/common/context-error-banner/context-error-banner.component';
 
@@ -43,7 +42,6 @@ import { ContextErrorBanner } from '../../../ui/common/context-error-banner/cont
         MatTabsModule,
         MatIconButton,
         RouterModule,
-        ErrorBanner,
         BannerText,
         ContextErrorBanner
     ]

nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-progress-dialog/change-version-progress-dialog.html

@@ -18,10 +18,7 @@
 <h2 mat-dialog-title>Change Flow Version</h2>
 @if (flowUpdateRequest$ | async; as versionChangeRequest) {
     @if (versionChangeRequest.request.complete && versionChangeRequest.request.failureReason) {
-        <error-banner
-            [messages]="[versionChangeRequest.request.failureReason]"
-            [showErrorIcon]="true"
-            [allowDismiss]="false"></error-banner>
+        <banner [messages]="[versionChangeRequest.request.failureReason]" [allowDismiss]="false"></banner>
     }
 }
 <div class="change-version-progress">

nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-progress-dialog/change-version-progress-dialog.ts

@@ -22,11 +22,11 @@ import { FlowUpdateRequestEntity } from '../../../../../state/flow';
 import { Observable, of } from 'rxjs';
 import { AsyncPipe } from '@angular/common';
 import { MatProgressBar } from '@angular/material/progress-bar';
-import { ErrorBanner } from '@nifi/shared';
+import { Banner } from '@nifi/shared';
 
 @Component({
     selector: 'change-version-progress-dialog',
-    imports: [MatDialogTitle, MatDialogModule, MatButton, AsyncPipe, MatProgressBar, ErrorBanner],
+    imports: [MatDialogTitle, MatDialogModule, MatButton, AsyncPipe, MatProgressBar, Banner],
     templateUrl: './change-version-progress-dialog.html',
     styleUrl: './change-version-progress-dialog.scss'
 })

nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/context-error-banner/context-error-banner.component.html

@@ -17,4 +17,4 @@
   ~ under the License.
   -->
 
-<error-banner [messages]="messages$ | async" (dismiss)="dismiss()"></error-banner>
+<banner [messages]="messages$ | async" (dismiss)="dismiss()"></banner>

nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/context-error-banner/context-error-banner.component.ts

@@ -25,12 +25,12 @@ import { clearBannerErrors } from '../../../state/error/error.actions';
 import { Observable } from 'rxjs';
 import { selectBannerErrors } from '../../../state/error/error.selectors';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
-import { ErrorBanner } from '@nifi/shared';
+import { Banner } from '@nifi/shared';
 import { ErrorContextKey } from '../../../state/error';
 
 @Component({
     selector: 'context-error-banner',
-    imports: [CommonModule, ErrorBanner],
+    imports: [CommonModule, Banner],
     templateUrl: './context-error-banner.component.html',
     styleUrl: './context-error-banner.component.scss'
 })

nifi-frontend/src/main/frontend/libs/shared/src/components/connector-configuration-summary-step/connector-configuration-summary-step.component.html

@@ -74,11 +74,11 @@
                 </div>
 
                 @if (verifyAllError()) {
-                    <error-banner
+                    <banner
                         [messages]="[verifyAllError()!]"
                         [allowDismiss]="false"
                         data-qa="verify-all-error-banner">
-                    </error-banner>
+                    </banner>
                 }
 
                 <!-- Verify All Steps -->
@@ -129,11 +129,11 @@
 
                             @let generalMessages = getGeneralErrorMessages(stepConfig.configurationStepName);
                             @if (generalMessages.length > 0) {
-                                <error-banner
+                                <banner
                                     [messages]="generalMessages"
                                     [allowDismiss]="false"
                                     data-qa="step-general-verification-errors">
-                                </error-banner>
+                                </banner>
                             }
 
                             @for (group of stepConfig.propertyGroupConfigurations; track group.propertyGroupName) {

nifi-frontend/src/main/frontend/libs/shared/src/components/connector-configuration-summary-step/connector-configuration-summary-step.component.ts

@@ -23,7 +23,7 @@ import { MatTooltip } from '@angular/material/tooltip';
 import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
 import { NifiSpinnerDirective } from '../../directives/spinner/nifi-spinner.directive';
 import { PropertyGroupCard } from '../property-group-card/property-group-card.component';
-import { ErrorBanner } from '../error-banner/error-banner.component';
+import { Banner } from '../banner/banner.component';
 import { ConnectorConfiguration, ConnectorPropertyDescriptor, ConfigVerificationResult } from '../../types';
 import {
     hasPropertyValue,
@@ -41,7 +41,7 @@ import {
         NgxSkeletonLoaderModule,
         NifiSpinnerDirective,
         PropertyGroupCard,
-        ErrorBanner
+        Banner
     ],
     templateUrl: './connector-configuration-summary-step.component.html',
     styleUrl: './connector-configuration-summary-step.component.scss'

nifi-frontend/src/main/frontend/libs/shared/src/components/connector-wizard/connector-configuration-step/connector-configuration-step.component.html

@@ -34,12 +34,12 @@
                 </wizard-context-banner>
 
                 <!-- Step-specific general errors (from verify-all on summary page) -->
-                <error-banner
+                <banner
                     [messages]="generalVerificationErrors()"
                     [allowDismiss]="true"
                     (dismiss)="onDismissGeneralVerificationErrors()"
                     data-qa="step-general-verification-errors">
-                </error-banner>
+                </banner>
 
                 @if (stringListOrphanStripBannerEntries().length > 0) {
                     <div class="mb-5" role="status" aria-live="polite" data-qa="string-list-orphan-strip-banner">

nifi-frontend/src/main/frontend/libs/shared/src/components/connector-wizard/connector-configuration-step/connector-configuration-step.component.ts

@@ -44,7 +44,7 @@ import { UploadService } from '../../../services/upload.service';
 import { ConnectorConfigurationService } from '../../../services/connector-configuration.service';
 import { ConnectorPropertyInput } from '../../connector-property-input/connector-property-input.component';
 import { StringListOrphansStrippedEvent } from '../../connector-property-input/connector-property-input.types';
-import { ErrorBanner } from '../../error-banner/error-banner.component';
+import { Banner } from '../../banner/banner.component';
 import { StatusBanner } from '../../status-banner/status-banner.component';
 import { StatusBannerDescriptionDirective } from '../../status-banner/status-banner.directives';
 import { fromValueReference, toValueReference, SecretReferenceOptions } from '../../../services/value-reference.helper';
@@ -103,7 +103,7 @@ export interface StringListOrphanStripBannerEntry {
         WizardContextBanner,
         WizardStepDocumentationPanel,
         MatProgressSpinner,
-        ErrorBanner,
+        Banner,
         StatusBanner,
         StatusBannerDescriptionDirective
     ],

nifi-frontend/src/main/frontend/libs/shared/src/components/index.ts

@@ -28,7 +28,6 @@ export * from './codemirror/themes/baseTheme';
 export * from './yes-no-dialog/yes-no-dialog.component';
 export * from './tooltips/property-hint-tip/property-hint-tip.component';
 export * from './tooltips/text-tip/text-tip.component';
-export * from './error-banner/error-banner.component';
 export * from './banner/banner.component';
 export * from './wizard/wizard.component';
 export * from './connector-wizard/connector-wizard.types';