NIFI-15964 Update OverlappingConnectionsBanner to use StatusBanner#11307
Open
venkateshwaracholan wants to merge 1 commit into
Open
NIFI-15964 Update OverlappingConnectionsBanner to use StatusBanner#11307venkateshwaracholan wants to merge 1 commit into
venkateshwaracholan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15964
Update OverlappingConnectionsBannerComponent to use the shared StatusBanner component.
Replaced custom .overlapping-connections-banner markup with and statusBannerTitle / statusBannerDescription directives from @nifi/shared
Removed _overlapping-connections-banner.component-theme.scss and related theme wiring from styles.scss since styling is provided by StatusBanner
Kept overlap navigation links in the default StatusBanner content slot and preserved allowDismiss="false" behavior
Updated unit tests to verify StatusBanner usage through By.directive(StatusBanner) and assert the caution variant
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation