NIFI-15991 - Flaky test TestFileSystemRepository.testClaimsArchivedWhenMarkedDestructable

[pvillard31]

Summary

NIFI-15991 - Flaky test TestFileSystemRepository.testClaimsArchivedWhenMarkedDestructable

Error:  Tests run: 38, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 72.03 s <<< FAILURE! -- in org.apache.nifi.controller.repository.TestFileSystemRepository
Error:  org.apache.nifi.controller.repository.TestFileSystemRepository.testClaimsArchivedWhenMarkedDestructable -- Time elapsed: 30.45 s <<< ERROR!
java.util.concurrent.TimeoutException: testClaimsArchivedWhenMarkedDestructable() timed out after 30 seconds
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	Suppressed: java.lang.InterruptedException: sleep interrupted
		at java.base/java.lang.Thread.sleep0(Native Method)
		at java.base/java.lang.Thread.sleep(Thread.java:509)
		at org.apache.nifi.controller.repository.TestFileSystemRepository.testClaimsArchivedWhenMarkedDestructable(TestFileSystemRepository.java:178)

Stabilizes the intermittently failing TestFileSystemRepository.testClaimsArchivedWhenMarkedDestructable by running it against a local FileSystemRepository that reports unlimited usable space, so the background archive-cleanup task can no longer reclaim the freshly archived claim and drive the archive count back to 0 on disk-constrained CI hosts. Also replaces the unbounded while (count != 1) busy-wait with a bounded 10s poll that fails with diagnostic context (archive count, live vs. archive path existence) instead of an opaque TimeoutException.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
• Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using ./mvnw clean install -P contrib-check
  • JDK 21
  • JDK 25

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[markap14]

Changes LGTM, thanks @pvillard31! +1