java.source.base: Collection/Stream focused code renovation - #9553
Open
mbien wants to merge 1 commit into
Open
Conversation
Use potentially more efficient shortcuts like getFirst/Last(), reversed(), computeIfAbsent(), removeIf(), toList() etc. Remove redundant calls (e.g stream().forEach()) or dead code.
mbien
added
Code cleanup
mbien
commented
Aug 10, 2026
Comment on lines
-197
to
-198
| //J2ME preprocessor support | ||
| private final FilterListener filterListener; |
Member
Author
There was a problem hiding this comment.
this field was never read after init -> removed dead code paths
Member
Author
|
@lkishalmi @matthiasblaesing anyone else wants to take a quick look at this? |
matthiasblaesing
approved these changes
Aug 26, 2026
matthiasblaesing
left a comment
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
Looks sane to me. Some of the changes I would not have a applied (for example moving from String#format to String#formatted, but overall this looks like a sane cleanup.
Member
Author
|
thanks for checking, going to go through it again myself and rebase before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use potentially more efficient shortcuts like
getFirst/Last(),reversed(),computeIfAbsent(),removeIf(),toList()etc.Remove redundant calls (e.g
stream().forEach()) or dead code.Refactored using jackpot scripts but checked hits for side effects.