Skip to content

[5.0] Myfaces 4721 - AUTOCOMPLETE_VIEW_STATE_VALUE #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[5.0] Myfaces 4721 - AUTOCOMPLETE_VIEW_STATE_VALUE #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions impl/src/main/java/org/apache/myfaces/config/webparameters/MyfacesConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,13 +519,14 @@ public class MyfacesConfig
private static final boolean USE_FLASH_SCOPE_PURGE_VIEWS_IN_SESSION_DEFAULT = false;

/**
* Add autocomplete="off" to the view state hidden field. Enabled by default.
* Add autocomplete="..." to the view state hidden field. Set to "one-time-code" by default. (MYFACES-4721)
* Note: 'disable' means the autocomplete attribute is NOT added to the input html tag
*/
@JSFWebConfigParam(since="2.2.8, 2.1.18, 2.0.24", expectedValues="true, false",
defaultValue="false", group="state")
public static final String AUTOCOMPLETE_OFF_VIEW_STATE =
"org.apache.myfaces.AUTOCOMPLETE_OFF_VIEW_STATE";
private static final boolean AUTOCOMPLETE_OFF_VIEW_STATE_DEFAULT = false;
@JSFWebConfigParam(since="5.0.0", expectedValues="disable, off, one-time-code",
defaultValue="one-time-code", group="state")
public static final String AUTOCOMPLETE_VIEW_STATE_VALUE =
"org.apache.myfaces.AUTOCOMPLETE_VIEW_STATE_VALUE";
private static final String AUTOCOMPLETE_VIEW_STATE_VALUE_DEFAULT = "one-time-code";

/**
* Set the max time in milliseconds set on the "Expires" header for a resource rendered by
Expand Down Expand Up @@ -837,7 +838,7 @@ public class MyfacesConfig
private boolean serializeStateInSession = false;
private boolean compressStateInSession = COMPRESS_STATE_IN_SESSION_DEFAULT;
private boolean useFlashScopePurgeViewsInSession = USE_FLASH_SCOPE_PURGE_VIEWS_IN_SESSION_DEFAULT;
private boolean autocompleteOffViewState = AUTOCOMPLETE_OFF_VIEW_STATE_DEFAULT;
private String autocompleteOffViewState = AUTOCOMPLETE_VIEW_STATE_VALUE_DEFAULT;
private long resourceMaxTimeExpires = RESOURCE_MAX_TIME_EXPIRES_DEFAULT;
private boolean lazyLoadConfigObjects = LAZY_LOAD_CONFIG_OBJECTS_DEFAULT;
private String elResolverComparator;
Expand Down Expand Up @@ -1163,8 +1164,8 @@ else if (refreshTransientBuildOnPSS.equalsIgnoreCase("true") ||
cfg.useFlashScopePurgeViewsInSession = getBoolean(extCtx, USE_FLASH_SCOPE_PURGE_VIEWS_IN_SESSION,
USE_FLASH_SCOPE_PURGE_VIEWS_IN_SESSION_DEFAULT);

cfg.autocompleteOffViewState = getBoolean(extCtx, AUTOCOMPLETE_OFF_VIEW_STATE,
AUTOCOMPLETE_OFF_VIEW_STATE_DEFAULT);
cfg.autocompleteOffViewState = getString(extCtx, AUTOCOMPLETE_VIEW_STATE_VALUE,
AUTOCOMPLETE_VIEW_STATE_VALUE_DEFAULT);

cfg.resourceMaxTimeExpires = getLong(extCtx, RESOURCE_MAX_TIME_EXPIRES,
RESOURCE_MAX_TIME_EXPIRES_DEFAULT);
Expand Down Expand Up @@ -1636,7 +1637,7 @@ public boolean isUseFlashScopePurgeViewsInSession()
return useFlashScopePurgeViewsInSession;
}

public boolean isAutocompleteOffViewState()
public String getAutocompleteOffViewState()
{
return autocompleteOffViewState;
}
Expand Down
5 changes: 3 additions & 2 deletions impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,10 @@ private void writeViewStateField(FacesContext facesContext, ResponseWriter respo
null);
}
responseWriter.writeAttribute(HTML.VALUE_ATTR, serializedState, null);
if (myfacesConfig.isAutocompleteOffViewState())
String autoCompleteValue = myfacesConfig.getAutocompleteOffViewState();
if (!autoCompleteValue.equals("disable"))
{
responseWriter.writeAttribute(HTML.AUTOCOMPLETE_ATTR, "off", null);
responseWriter.writeAttribute(HTML.AUTOCOMPLETE_ATTR, autoCompleteValue, null);
}
responseWriter.endElement(HTML.INPUT_ELEM);
}
Expand Down