Skip to content

Add @nullable annotations throughout the codebase #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add @nullable annotations throughout the codebase #2386

wants to merge 1 commit into from

Conversation

@Pankraz76
Copy link
Contributor

@Pankraz76 Pankraz76 commented May 23, 2025

@Pankraz76 Pankraz76 changed the title Add @nonnull and @nullable annotations throughout the codebase Add @nullable annotations throughout the codebase May 23, 2025
@Pankraz76 Pankraz76 mentioned this pull request May 23, 2025
Open
@Pankraz76 Pankraz76 force-pushed the fix-AnnotateNullableMethods branch from 0b4edee to ff4ea3b Compare May 23, 2025 20:33
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented May 23, 2025 •
edited
Loading

idk if this is any good. This is to large as well.
@gnodet @elharo

@Pankraz76 Pankraz76 force-pushed the fix-AnnotateNullableMethods branch from ff4ea3b to f63defb Compare May 23, 2025 20:42
@Pankraz76 Pankraz76 marked this pull request as ready for review May 28, 2025 16:37
gnodet
gnodet requested changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add these annotations in compat/* subprojects.

@Pankraz76 Pankraz76 force-pushed the fix-AnnotateNullableMethods branch from 127cf0b to fe9e2e9 Compare June 4, 2025 14:39
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Jun 10, 2025

@slachiewicz why this one not?

@Pankraz76 Pankraz76 closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnodet gnodet gnodet requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @gnodet