Pull #2292: Modernize codebase with Java improvements - remove dead code
#2293
+0
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
test-getModuleName
branch
from
4f7325e to
d27413a
Compare
|
[INFO] BUILD SUCCESS 
|
|
The PR removes part of the API. It's not dead code, it's an API. |
yes i was wondering about this myself. But then adding a simple test to make it used is a good thing, right? |
Sure. Please do not prefix all your PRs with "Pull #2292: Modernize codebase with Java improvements - ", especially when they are not about java improvements ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull #2292:
Modernize codebase with Java improvements - remove dead code