[MNG-8229] CI Friendly versions confuse model pool #1690
Closed
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the method (there is one GA inside reactor), but this still does not fix the issue, now it fails elsewhere. The problem in short is CI friendly version and its half-assed solution as model version "suddenly" change from file-activated models to effective ones. --- https://issues.apache.org/jira/browse/MNG-8229
gnodet
reviewed
Aug 30, 2024
| "Multiple modules with key " + a.getGroupId() + ':' + a.getArtifactId()); | ||
| }) | ||
| .orElse(null); | ||
| } |
There was a problem hiding this comment.
This does not change the behaviour, right ? What's the point ?
There was a problem hiding this comment.
Oh, it does change the behaviour, as if there's a single version, it will always be used, even if there's a version mismatch. I think that's wrong.
Multiple versions of the same GA inside a reactor is a supported (albeit rare) use case.
If the model pool is being filled, we can't rely on the existence of a single version (while the second may not have been read yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the method (there is one GA inside reactor), but this still does not fix the issue, now it fails elsewhere.
The problem in short is CI friendly version and its half-assed solution as model version "suddenly" change from file-activated models to effective ones.
https://issues.apache.org/jira/browse/MNG-8229