chore(deps-dev): bump @electron/asar from 3.4.1 to 4.3.0 - #3957
Conversation
Bumps [@electron/asar](https://github.com/electron/asar) from 3.4.1 to 4.3.0. - [Release notes](https://github.com/electron/asar/releases) - [Changelog](https://github.com/electron/asar/blob/main/CHANGELOG.md) - [Commits](electron/asar@v3.4.1...v4.3.0) --- updated-dependencies: - dependency-name: "@electron/asar" dependency-version: 4.3.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
I reviewed this PR at exact head Spec: GO — no P0–P3
The lockfile growth is the expected npm representation after the v4 root can no longer be deduplicated with nested consumers that still need v3. Standards: 2×P3 — non-blocking but needs housekeeping
No Fowler judgment smell; the package/lock delta is mechanical and entropy-neutral. Title, bot identification, Signed-off-by, Node floor, and API compatibility otherwise pass. Other checks: What I did not check: full local suite beyond the focused 18/18 archive checks. Gate: exact head has no P0–P2 and all required checks are green. The two P3 template/branch findings are non-blocking housekeeping; the PR can be approved and merged once the automation exception is acknowledged, or the template is completed.
|
Astro-Han
left a comment
There was a problem hiding this comment.
Bumps the @electron/asar devDependency from 3.4.1 to 4.3.0, a major bump, touching only package.json and package-lock.json.
What I checked, since a major bump is not automatically safe:
- Our entire API surface is three calls:
createPackageinscripts/verify-packaged-app.test.mjs:160, andgetRawHeader/extractFileinscripts/verify-packaged-app.mjs:813,829,948,951,973. All three still exist in 4.x. We never touch the CLI, so 4.x replacingcommanderreaches nothing of ours. @electron/asar@4.3.0declaresengines.node: >=22.12.0, which our>=22.19.0already satisfies.- The
packagecheck is green. That job actually packages and verifies a real archive, so the three calls above ran against 4.3.0 rather than merely typechecking. That, and not the changelog, is what makes this safe to take. - 4.x is mostly hardening of archive parsing (header validation, offset bounds, symlink traversal, depth limits). We only read archives we just built, so this is not a live exposure being closed, but it is the direction we want the dependency to move.
Approving.
AI use: Claude Code (Opus) enumerated our call sites, checked the declared engine range against ours, and confirmed the package job exercises the archive path. The reviewer of record reviewed and accepted this.
简体中文
将 devDependency @electron/asar 从 3.4.1 升到 4.3.0,跨大版本,只改 package.json 和 package-lock.json。
跨大版本不能默认安全,所以核对了:
- 我们用到的 API 只有三个:
verify-packaged-app.test.mjs:160的createPackage,以及verify-packaged-app.mjs:813,829,948,951,973的getRawHeader/extractFile。三者在 4.x 中均在。我们不用它的 CLI,因此 4.x 换掉commander影响不到我们。 @electron/asar@4.3.0声明engines.node: >=22.12.0,我们的>=22.19.0满足。package检查已绿。该 job 会真正打包并校验归档,所以上面三个调用是在 4.3.0 上真跑过,而不只是过了类型。让这次升级可接受的是这一点,不是 changelog。- 4.x 主要是归档解析加固(头部校验、偏移越界、符号链接穿越、深度限制)。我们只读自己刚构建的归档,所以并非在关闭一个现存暴露面,但这是我们希望该依赖走的方向。
Approve。
Bumps @electron/asar from 3.4.1 to 4.3.0.
Release notes
Sourced from @electron/asar's releases.
... (truncated)
Commits
01bc908feat: store duplicated file contents only once when packing (#465)2bf3408build(deps): bump postcss from 8.5.20 to 8.5.24 (#463)ab7bc41build(deps): bump undici from 7.28.0 to 7.29.0 (#462)d934f9abuild(deps): bump actions/setup-node from 6.4.0 to 7.0.0 (#459)1ce80a7build(deps): bump actions/checkout from 7.0.0 to 7.0.1 (#460)9428c25build(deps): bump brace-expansion from 5.0.7 to 5.0.8 (#461)c4354aeci: stop setting the Opened project field (#456)8e12da2build(deps): bump postcss from 8.5.15 to 8.5.20 (#458)4d5d687build(deps): bump linkify-it from 5.0.1 to 5.0.2 (#457)0959a13build(deps): bump brace-expansion from 5.0.6 to 5.0.7 (#455)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@electron/asarsince your current version.Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)