test(desktop): await Plan turn settlement - #3836
Open
liugddx wants to merge 1 commit into
Open
Conversation
Generated-by: Codex
Member
Author
|
@Astro-Han Hosted exact-head test is green, including the complete Desktop e2e suite. This PR keeps the existing catalog-failure assertions and adds only the authoritative runningTurnIds settlement barrier before the latch. Could you please review when available? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize the Plan/catalog-refresh Desktop e2e scenarios by waiting for Runtime Host's authoritative terminal turn ownership before latching the next session-catalog read.
runningTurnIdsto be known-empty;Why
The fake backend response can become visible before Runtime Host publishes terminal turn ownership. The tests previously treated that text as a completion barrier, then observed the Plan row enabled briefly before a late running projection disabled it between the assertion and click.
This reproduced on two unrelated #3789 heads:
The new barrier uses the same known-empty
runningTurnIdsauthority already used by the Desktop streaming e2e suite. It runs beforesessions.listis latched, so the latch still owns only the Plan commit's catalog refresh.Verification
npm run lintnpm run format:checknpm run buildnpm run typechecknpx knip --workspace apps/desktopgit diff --checkn- Hosted [test`](https://github.com/apache/maka/actions/runs/32913940933/job/98013529513) passed in 8m43s, including the complete Desktop e2e suite.Local Windows Electron did not create its first test window, so the focused runtime assertion requires the hosted Linux/xvfb CI lane. The failure occurred before the test body and is not counted as passing evidence.
AI use
Tool and scope: Codex analyzed the two hosted traces, added the test-only settlement barrier, and ran the listed local gates.
Fixes #3814.
Checklist
testpasses on exact headcf56ebbd1Does this PR entail a change in behavior?