Skip to content

fix(desktop): keep daily-review active-task rows inside the clamped column - #3831

Merged
Astro-Han merged 1 commit into
apache:mainfrom
liuxiaocs7:fix/daily-review-active-task-overflow
Aug 26, 2026
Merged

fix(desktop): keep daily-review active-task rows inside the clamped column#3831
Astro-Han merged 1 commit into
apache:mainfrom
liuxiaocs7:fix/daily-review-active-task-overflow

Conversation

@liuxiaocs7

@liuxiaocs7 liuxiaocs7 commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

On the desktop 每日回顾 / Daily Review tab, rows in the 活跃任务 / active conversations list overflowed the clamped ~900px page column: when a session's lastMessagePreview is long, the row stretched past the column and its trailing timestamp (plus the 费用 / cost metric in the totals strip) was pushed off the right edge and clipped by the Layout's overflow: hidden.

Root cause: .maka-daily-review-content is display: grid with no explicit grid-template-columns, so its implicit auto track sized to max-content. The row preview is a single white-space: nowrap line, so its max-content width is the full untruncated string, and the auto track grew to fit it. Sibling module lists don't hit this because their List sits directly in .maka-module-page-panel, which already carries the grid-template-columns: minmax(0, 1fr) guard; Daily Review nests the list one grid layer deeper and that inner grid lacked it.

Fix: add the same one-line guard to .maka-daily-review-content. The column is then never wider than the panel, so the row shrinks and the preview truncates with an ellipsis, keeping the timestamp visible.

Fixes #3830

Verification

Reproduced and validated against the real Storybook DOM (product-module-hubs--host-automations-daily-review) with Playwright at a 1400px viewport, injecting a long preview into the active-task rows:

List width Timestamp right edge Column right edge Overflow
Before 1502px 1762 1128 yes
After (minmax(0, 1fr)) 860px 1120 1128 no

After the fix the preview truncates with an ellipsis, the relative-time label is fully visible, and the previously-clipped 费用 metric column reappears.

Not run: unit/integration suites (CSS-only layout change, no logic touched).

before
image

after
image

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Claude Code (claude-opus-4-8) — diagnosed the overflow, reproduced it via Playwright against the Storybook DOM, and authored the one-line CSS fix. The commit carries a Generated-by trailer.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

…olumn

.maka-daily-review-content was display:grid with no explicit column
template, so its implicit auto track sized to max-content. The active-
conversations rows carry a white-space:nowrap preview whose full width
then stretched the track past the ~900px clamped column, pushing each
row's trailing timestamp (and the cost metric) off the plate where the
Layout clips it.

Add the same guard .maka-module-page-panel already documents —
grid-template-columns: minmax(0, 1fr) — so the column is never wider than
the panel and the row shrinks and truncates instead.

Verified against the real Storybook DOM with a long injected preview: the
List returns from 1502px to the 860px column width and the timestamp's
right edge moves inside the column edge (no overflow).

Generated-by: Claude Code (claude-opus-4-8)

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this head and found no blocking issues.

Single-line fix for daily-review active-task overflow (clamped column); hosted test: SUCCESS.

No P0-P3.

简体中文该头无阻断。

Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — 624d719, fix, no P0-P3, hosted test SUCCESS.


Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.

@Astro-Han
Astro-Han merged commit a32f315 into apache:main Aug 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

daily-review active-task rows overflow the clamped column and clip their timestamps

2 participants