fix(desktop): prevent collapsed workbar flash - #3794
Conversation
|
CI note: the current failure occurs before the desktop build and is inherited from |
Astro-Han
left a comment
There was a problem hiding this comment.
I reviewed this head and found a blocking issue.
[P1] Claimed queue-test migration not present — build fails
execution-host-queue.test.ts:248/249/271 still references queryTurn/stopTurn/startTurn missing on RuntimeHostConnection. Hosted test is red.
简体中文
存在测试迁移缺失阻断。Make the lazy Workbar fallback mirror the resolved surface visibility so creating a session cannot briefly open a collapsed panel. Add Electron coverage that records transient right-panel visibility during the first send. Generated-by: Codex
9114804 to
5f38f4e
Compare
|
Rebased onto current Local verification on
Please re-review the refreshed head. |
Astro-Han
left a comment
There was a problem hiding this comment.
Update on 5f38f4e:
The prior P1 (queue-test still references removed RuntimeHostConnection methods) is now closed. The new head has rebased onto main with #3796's fix, execution-host-queue.test.ts no longer references queryTurn/startTurn/stopTurn (grep 0), and hosted test is now pass (run 32852297860).
The workbar-host fallback logic remains correct (no P0-P3) and is now merge-ready pending human decision.


Summary
Verification
origin/main: the new Electron test observedvisibleRightWorkbar === trueduring the first send.npm --workspace @maka/ui run buildnpx tsc -p apps/desktop/tsconfig.renderer.json --noEmit --pretty falsenpx biome lint apps/desktop/src/renderer/features/workbar/ui/workbar-host.tsx apps/desktop/e2e/session-workbar.spec.tsnpm --workspace @maka/desktop run build:renderernode --test apps/desktop/dist/main/__tests__/workbar-boundary.test.js apps/desktop/dist/main/__tests__/workbar-model.test.js(14/14 passed)Root cause
Creating the first session mounts
WorkbarHostwhile the lazyWorkbarSurfaceis still resolving. The old Suspense fallback always rendered a visible 480 px right panel, even whenrightCollapsedwas true. Once the real surface loaded, its collapsed state hid that panel, producing the brief flash. The fallback now derives its rendered placements from the samehidden,rightCollapsed, andbottomOpenstate as the resolved surface.AI use
Select exactly one:
Tool(s) and scope: Codex investigated the render path, implemented the fix and regression test, and ran the verification described above.
Checklist
Does this PR entail a change in behavior?