test(ui): pin the humanized provider retry banner copy across locales and scales - #3701
Merged
Astro-Han merged 1 commit intoAug 25, 2026
Conversation
… and scales Covers the providerRetryScheduled copy introduced by apache#3611: zh/en outputs across second/minute/hour/day scales, the ceil-to-one-second floor for zero-length waits, and that zero-order units are skipped rather than rendered as "0分" / "0m". Generated-by: maka
Astro-Han
reviewed
Aug 25, 2026
Astro-Han
left a comment
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
I reviewed this head and found no blocking issues.
Single file adds locale/scale focused tests for provider retry display; no production logic.
No P0-P3. Checks on daf66dc70 — code GO.
简体中文
该头未发现阻断。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3611 (and the closed #3402): @Astro-Han asked for the unit-test cases from #3402 to be sent standalone, since #3611 shipped the formatter without tests.
This adds one focused test pinning
providerRetryScheduledin both locales:45秒,1分 15秒,4小时 28分 3秒,1天 1小时 1分 1秒— and the en equivalents)1秒后重试/Retrying in 1sand never0秒后重试0分/0mAlso documents (per Astro-Han's note on #3402) that the zh short-delay string intentionally changed shape:
45 秒后重试→45秒后重试(space dropped).Generated-by: maka