Skip max score computation when sorting by relevance in BlockGroupingCollector#15942
Open
gaobinlong wants to merge 2 commits intoapache:mainfrom
Open
Skip max score computation when sorting by relevance in BlockGroupingCollector#15942gaobinlong wants to merge 2 commits intoapache:mainfrom
gaobinlong wants to merge 2 commits intoapache:mainfrom
Conversation
…Collector Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
Author
|
Hi @benwtrent , please help to review this PR when you're convenient, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In BlockGroupingCollector.getTopGroups(), we firstly compute the groupMaxScore by iterating on each group docs to get the max value, then compute the totalMaxScore by
Math.max(maxScore, groupMaxScore), both can be optimized when the sort is by relevance.For the
groupMaxScore, we can get the maxScore from the top scoreDoc in the merged top docs. For thetotalMaxScore, we can get it from the groups[0] directly if sort by relevance.Performance benchmark: