Change TopGroups.merge() to accept a list of TopGroups#15897
Open
gaobinlong wants to merge 4 commits intoapache:mainfrom
Open
Change TopGroups.merge() to accept a list of TopGroups#15897gaobinlong wants to merge 4 commits intoapache:mainfrom
gaobinlong wants to merge 4 commits intoapache:mainfrom
Conversation
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
Author
|
Hi @dweiss , please help to review this PR, thank you! |
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
jainankitk
approved these changes
Apr 7, 2026
Contributor
jainankitk
left a comment
jainankitk
left a comment
There was a problem hiding this comment.
Need to resolve merge conflicts before this PR can be merged
lucene/grouping/src/test/org/apache/lucene/search/grouping/BaseGroupSelectorTestCase.java
Outdated
Show resolved
Hide resolved
lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TopGroups.merge() accepting an array of TopGroups is annoying, we need to suppress the
uncheckedandrawtypeswhen declaring an array of TopGroups, a long lasting TODO in the test code also mention this, so this PR changes it to accept a list of TopGroups instead of array.This is a breaking change, we can on-board it in version 11.0.