Fix TopGroupsCollector#getTopGroups() returning NaN maxScore when a group has no hits#15873
Open
gaobinlong wants to merge 4 commits intoapache:mainfrom
Open
Fix TopGroupsCollector#getTopGroups() returning NaN maxScore when a group has no hits#15873gaobinlong wants to merge 4 commits intoapache:mainfrom
gaobinlong wants to merge 4 commits intoapache:mainfrom
Conversation
…roup has no hits Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
Author
|
Hi @dweiss , could you help to review this PR? Thank you~ |
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15872, use
nonNANmax()instead ofMath.max()in TopGroupsCollector#getTopGroups() to avoid generating wrong NaN maxScore in the final TopGroups result.