Open
Conversation
7f12860 to
50a3b97
Compare
50a3b97 to
7b7a68c
Compare
Author
|
@uschindler would be great if you could take a look at this, thanks! |
Contributor
I can have a look, but I think @jpountz is the better one to look at this Uwe |
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
Author
|
sure thanks @uschindler, @jpountz, could you please help review this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Made two optimisations here:
1. Reuse inner LeafCollector : The anonymous
LeafCollectorwas allocated inside the innerdo-whileloop for every sub-scorer in every window. Moved to a reusable field (innerCollector), eliminating per-window allocations and GC pressure. Measured 4.3x faster in allocation microbenchmark.2. Inline score reset during replay : Replaced
Arrays.fill(windowScores, 0f)(which zeros all 4096 entries unconditionally) withwindowScores[doc] = 0finline during the replay loop. Since the replay already readswindowScores[doc], the reset piggybacks on the same cache line access at near-zero cost.Benchmark evidence (window=4096, 200k iterations, best of 3):
Faster at ALL densities : never slower, even when fully saturated.
Precedent
For both I followed
MaxScoreBulkScorer, which already uses selective score reset during its replay loop.