Add missing uses declarations in module descriptor
#3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All `ServiceLoader.load()` calls need a `uses` clause in the JPMS module descriptor. This PR: - Adds the missing `@ServiceConsumer` annotation to `CoreDefaultBundle`. - To simplify code review, it places `@ServiceConsumer` on each class that makes a `ServiceLoader.load` call and only those classes. Closes #3250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
ServiceLoader.load()calls need ausesclause in the JPMS module descriptor. This PR:@ServiceConsumerannotation toCoreDefaultBundle.@ServiceConsumeron each class (even a test case) that makes aServiceLoader.loadcall and only those classes.Fixes #3250
Since we don't have JPMS tests in the main repo, this PR is blocked by apache/logging-log4j-samples#231