Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate log4j-api-test to junit5 #3218

Draft
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

Realtin
Copy link
Contributor

@Realtin Realtin commented Nov 19, 2024

We are from Neighbourhoodie, the implementation partner of the STF Bug Resilience Program. This work is part of our agreed Milestone 1. Upgrade from JUnit 4 to JUnit 5.
This PR migrates the tests located in log4j-api-test to JUnit5.

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

@Realtin
Copy link
Contributor Author

Realtin commented Nov 19, 2024

Hi @vy I ran into a problem after refactoring the SecurityManagerRule to an Extension. It seems to end up in a loop at: LoaderUtilSecurityManagerTest$TestSecurityManager.checkPermission(LoaderUtilSecurityManagerTest.java:36)
and ends with an error:

org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException Error occurred in starting fork, check output in log
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:456) .... 

Do you have any pointers on how to solve this?

@ppkarwasz
Copy link
Contributor

@Realtin,

I'll look into it tomorrow.

@Realtin Realtin changed the title Log4j api test refactor junit5 Migrate log4j-api-test to junit5 Nov 21, 2024
@Realtin Realtin force-pushed the log4j-api-test_refactor_junit5 branch from b15b1e9 to dbf4fcd Compare December 11, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants