Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent asyncappender test timeout #416

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

swebb2066
Copy link
Contributor

This PR fixes #402 which is caused when more threads than cores (A Github runnuer is limited to only 2 cores) result in multiple thread in a std::atomic::compare_exchange_weak busy loop.

The scheduler then occasionally runs the thread where the compare_exchange succeeds, which make the test run extremely slowly.

@swebb2066 swebb2066 merged commit bb327eb into master Oct 17, 2024
32 checks passed
@swebb2066 swebb2066 deleted the fix_flaky_asyncappender_test branch October 17, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async appender in msys2 ucrt-x86_64-g++ occasionally blocks
2 participants