Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest version of Github actions for CI #399

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Use latest version of Github actions for CI #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/abi-compatibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
fail-fast: false

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
persist-credentials: false # do not persist auth token in the local git config
path: main
Expand All @@ -58,7 +58,7 @@ jobs:
cp $(find . -name compat_report.html) .
cp $(find . -name new-abi.dump) .

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: always()
with:
name: abi_info
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/log4cxx-cpp11.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-20.04
timeout-minutes: 38
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
persist-credentials: false # do not persist auth token in the local git config
path: main
Expand All @@ -45,5 +45,5 @@ jobs:
run: |
cd main
cd build
ctest -C Debug --output-on-failure -V
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -V flag I find is important, because if a test fails there will generally be some output that is useful.

It looks like we should be able to set it as an input, so that we can turn it on if required: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions

ctest -C Debug --output-on-failure

2 changes: 1 addition & 1 deletion .github/workflows/log4cxx-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
qt: OFF

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
persist-credentials: false # do not persist auth token in the local git config
path: main
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/log4cxx-ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
exitevents: OFF

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
persist-credentials: false # do not persist auth token in the local git config
path: main
Expand Down Expand Up @@ -95,4 +95,4 @@ jobs:
run: |
cd main
cd build
ctest -C Debug --output-on-failure -V
ctest -C Debug --output-on-failure
6 changes: 3 additions & 3 deletions .github/workflows/log4cxx-windows-static.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
os: windows-2022

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
persist-credentials: false # do not persist auth token in the local git config
path: main
Expand All @@ -46,7 +46,7 @@ jobs:

- name: 'Checkout VCPKG'
if: steps.restore-vcpkg-cache.outputs.cache-hit != 'true'
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: microsoft/vcpkg
path: vcpkg
Expand Down Expand Up @@ -83,6 +83,6 @@ jobs:
run: |
cd main
cd build
ctest -C Debug --output-on-failure -V
ctest -C Debug --output-on-failure


9 changes: 4 additions & 5 deletions .github/workflows/log4cxx-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,21 @@ jobs:
os: windows-2022

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
persist-credentials: false # do not persist auth token in the local git config
path: main

- name: 'Restore Prebuilt Dependencies'
id: restore-vcpkg-cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: vcpkg
key: ${{ runner.os }}-${{ matrix.name }}-cache-x64

- name: 'Checkout VCPKG'
if: steps.restore-vcpkg-cache.outputs.cache-hit != 'true'
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: microsoft/vcpkg
path: vcpkg
Expand Down Expand Up @@ -83,5 +83,4 @@ jobs:
run: |
cd main
cd build
ctest -C Debug --output-on-failure -V

ctest -C Debug --output-on-failure
4 changes: 2 additions & 2 deletions .github/workflows/package_code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
fail-fast: false

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
persist-credentials: false # do not persist auth token in the local git config
path: clean-checkout
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
sha512sum "apache-log4cxx-$VERSION.zip" > "apache-log4cxx-$VERSION.zip.sha512"
sha256sum "apache-log4cxx-$VERSION.zip" > "apache-log4cxx-$VERSION.zip.sha256"

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: always()
with:
name: 'Upload release files'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sonarcloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
SONAR_SERVER_URL: "https://sonarcloud.io"
BUILD_WRAPPER_OUT_DIR: build_wrapper_output_directory # Directory where build-wrapper output will be placed
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
persist-credentials: false # do not persist auth token in the local git config
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
Expand All @@ -44,7 +44,7 @@ jobs:
java-version: 17

- name: Set up Python 3.8 for gcovr
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: 3.8

Expand Down
Loading