Closed
Conversation
Contributor
Author
|
@jbonofre would be great if you can take a look 😃 once we agree on the requirements then I'll start adding javadocs, tests, feature etc. |
jbonofre
reviewed
Oct 26, 2022
Member
jbonofre
left a comment
There was a problem hiding this comment.
That's a good start. I will come back to you with more detailed feedback (busy at EclipseCon this week).
awrb
commented
Oct 26, 2022
awrb
commented
Oct 26, 2022
cache/commands/src/main/java/org/apache/karaf/cache/core/commands/Create.java
Outdated
Show resolved
Hide resolved
awrb
commented
Oct 26, 2022
cache/commands/src/main/java/org/apache/karaf/cache/core/commands/Invalidate.java
Outdated
Show resolved
Hide resolved
e06d478 to
14e9ca2
Compare
Contributor
Author
|
@jbonofre I made a proper pull request now (added docs, example, tests etc). I'm happy to introduce any changes if needed. |
Member
|
This PR is stale and old. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft phase (it works but it's not a proper component yet).
I'm opening a pr already so it can be reviewed before putting more work into it.
Some features:
Some open points:
CacheService) look like