Skip to content

MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 #20684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2025
Merged

MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 #20684

merged 2 commits into from
Oct 12, 2025
+7 −1

Conversation

DL1231
Copy link
Contributor

@DL1231 DL1231 commented Oct 10, 2025 •
edited by github-actions bot
Loading

from: #19513 (comment)

  1. Fix the task unitTest and integrationTest;
  2. Change the name to a method call name() for KeepAliveMode.

Reviewers: Ken Huang [email protected], dejan2609
[email protected], Chia-Ping Tsai [email protected]

@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions small Small PRs labels Oct 10, 2025
@chia7712
Copy link
Member

@DL1231 thanks for this patch. Please verify the fixed tasks on your local.

@DL1231
Copy link
Contributor Author

DL1231 commented Oct 11, 2025

Task unitTest and integrationTest before fix:
FBD368A4-20CF-468E-DDB7-0D36DB74D89A
B1775469-C977-4AED-917F-383489D2A047
after fix:
71AA7C0F-E2B7-48AB-DBBA-A7A42F6FCC63
C7B68749-EE60-49A5-C794-C0E879442BEC

Task aggregatedJavadoc before fix:
E8211113-66AD-41DE-B0CD-0CE3ECA5D553
after fix:
BA121145-C579-48C8-B44A-1EDC06AD35CD

m1a2st
m1a2st reviewed Oct 11, 2025
View reviewed changes
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test ./gradlew aggregatedJavadoc --no-parallel locally, it would generate the documents.

Image

@github-actions github-actions bot removed the triage PRs from the community label Oct 11, 2025
@chia7712 chia7712 mentioned this pull request Oct 12, 2025
Closed
@dejan2609
Copy link
Contributor

dejan2609 commented Oct 12, 2025 •
edited
Loading

Seems legit ✅

Sugegstion for @DL1231: maybe you can save a few lines like this: 18db4af

@chia7712
Copy link
Member 

./gradlew build -x test -PkeepAliveMode=session

This command is also failing. The related warnings stems from #10485, which enabled joint compilation. In addition, #16965 added the -Werror flag, which causes the warning to fail the build.

Perhaps we could add -Xlint:-path for the core module.

@dejan2609
Copy link
Contributor

@chia7712 let me digg around this one.

@chia7712
Copy link
Member

let me digg around this one.

go ahead

@dejan2609
Copy link
Contributor

Wrong place for s comment, mobile GitHub app is not precise.

@chia7712 chia7712 merged commit cf3e1fc into apache:trunk Oct 12, 2025
25 checks passed
@chia7712
Copy link
Member

Wrong place for s comment, mobile GitHub app is not precise.

don't worry. please file a PR for #20684 (comment) if you have other approach.

@chia7712
Copy link
Member

Otherwise, we will file a patch to add -Xlint:-path

@dejan2609
Copy link
Contributor

Perhaps we could add -Xlint:-path for the core module.

This should do the trick 🤞

And please pardon me for spamming via GitHuib mobile app above 🙂
Will be around, summon me if you need some help.

@apalan60 apalan60 mentioned this pull request Oct 13, 2025
Merged
@apalan60
Copy link
Contributor 

./gradlew build -x test -PkeepAliveMode=session

This command is also failing. The related warnings stems from #10485, which enabled joint compilation. In addition, #16965 added the -Werror flag, which causes the warning to fail the build.

Perhaps we could add -Xlint:-path for the core module.

Thanks for the discussion. I’ve opened a PR #20695 to address this issue.

chia7712 pushed a commit that referenced this pull request Oct 13, 2025
@apalan60
MINOR: Prevent joint compilation error in core under session keepAliv…
9f822fc 
…eMode (#20695)

In Scala/Java joint compilation, builds that run with
`keepAliveMode=SESSION` can fail in the `:core:compileScala` task. This
happens when `javac` is given a non-existent Java output directory on
its classpath.

```
Unexpected javac output: warning: [path] bad path element
".../core/build/classes/java/main": no such file or directory
error: warnings found and -Werror specified
```

This issue occurs after a clean build because
`core/build/classes/java/main` does not exist, as Java classes are
written to `classes/scala/main` during joint compilation. With `-Werror`
enabled, the resulting `[path]` warning is treated as an error and stops
the build.

This PR adds a workaround scoped to **SESSION** builds, while continuing
to investigate the underlying classpath assembly logic during joint
compilation.

Related discussion:
#20684 (comment)
Tracked by:
[KAFKA-19786](https://issues.apache.org/jira/browse/KAFKA-19786)

Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai
 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chia7712 chia7712 chia7712 approved these changes

+1 more reviewer

@m1a2st m1a2st m1a2st left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Gradle build or GitHub Actions ci-approved small Small PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DL1231 @chia7712 @dejan2609 @apalan60 @m1a2st