Skip to content

MINOR: build dependecies - version updates #20656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

MINOR: build dependecies - version updates #20656

wants to merge 1 commit into from
+10 −12

Conversation

dejan2609
Copy link
Contributor

@dejan2609 dejan2609 commented Oct 7, 2025 •
edited by github-actions bot
Loading

Extends from: #19513

details:

  • grgit: 4.1.1 -->> 5.3.3
  • scala-logging: 3.9.5 -->> 3.9.6
  • scalafmt: 3.7.14 -->> 3.9.10
  • org.owasp.dependencycheck gradle plugin: 12.1.3 -->> 12.1.6
  • com.diffplug.spotless gradle plugin: 7.2.1 -->> 8.0.0
  • Scala coverage:
       - scoverage: 2.0.11 -->> 2.3.0
       - Scala version for scoverage: 2.13.9 -->> 2.13.16 (i.e.
    org.scoverage:scalac-scoverage-plugin_2.13.16:2.3.0 will be used)
       - org.scoverage gradle plugin: 8.0.3 -->> 8.1

Reviewers: Chia-Ping Tsai [email protected]

@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions small Small PRs labels Oct 7, 2025
@chia7712
Copy link
Member

chia7712 commented Oct 8, 2025

@dejan2609 would you mind filing a PR to update all those dependencies?

@dejan2609
Copy link
Contributor Author

Yes, that is doable 🔧

@chia7712
Copy link
Member

chia7712 commented Oct 8, 2025

Yes, that is doable

I will merge #20652 first. Please update this PR with the necessary dependencies updates once that is done! thanks

@dejan2609 dejan2609 changed the title MINOR: Scala coverage: version update MINOR: build dependecies - version updates Oct 8, 2025
@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from a42860a to 91c0595 Compare October 8, 2025 08:06
@dejan2609
Copy link
Contributor Author

@chia7712 PR is ready for review.

@dejan2609
Copy link
Contributor Author

I will rebase onto trunk to pick up Java 25 build solution that was merged moments ago 🍀

@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from 91c0595 to d28b9a3 Compare October 8, 2025 08:26
@dejan2609
Copy link
Contributor Author

@chia7712 Test results are fine - only two unrelated tests failed (and for Java 17 build only) ✅

@dejan2609
Copy link
Contributor Author

Hold on - I will include scala logging also: https://central.sonatype.com/artifact/com.typesafe.scala-logging/scala-logging_2.13/3.9.6

@dejan2609 dejan2609 marked this pull request as draft October 8, 2025 11:02
@dejan2609 dejan2609 marked this pull request as ready for review October 8, 2025 11:10
@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from d28b9a3 to c6cbfec Compare October 8, 2025 11:10
@dejan2609
Copy link
Contributor Author

Another commit will be force-pushed to solve this:
image

@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from c6cbfec to 3f30f7b Compare October 8, 2025 12:36
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 8, 2025
@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 8, 2025 •
edited
Loading

@chia7712 this is (finally) ready for a review 🔎

chia7712
chia7712 reviewed Oct 8, 2025
View reviewed changes
@dejan2609 dejan2609 requested a review from chia7712 October 8, 2025 18:17
@github-actions github-actions bot removed the triage PRs from the community label Oct 9, 2025
chia7712
chia7712 reviewed Oct 9, 2025
View reviewed changes
@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from 9a2d85d to ca4ec09 Compare October 9, 2025 20:16
@dejan2609 dejan2609 requested a review from chia7712 October 9, 2025 20:18
@chia7712
Copy link
Member

It seems the JDkK 17 build keeps failing. I have triggered it again, so let's see what happens

@dejan2609
Copy link
Contributor Author

@chia7712 all in green now 🍀

@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 10, 2025 •
edited
Loading

@chia7712 I opt to bundle #20683 (--no-parallel switch for aggregatedJavadoc) here.
It really makes sense: both things are echoing Gradle 8 to 9 upgrade.

@dejan2609 dejan2609 mentioned this pull request Oct 10, 2025
Merged
@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from 8dc2fb3 to ca4ec09 Compare October 10, 2025 17:33
@dejan2609
Copy link
Contributor Author

@chia7712 all in green now 🟢 🍀 ✅

@dejan2609
MINOR: build dependecies - version updates
8a8b680 
details:
 - `grgit`: 4.1.1 -->> 5.3.3
 - `scala-logging`: 3.9.5 -->> 3.9.6
 - `scalafmt`: 3.7.14 -->> 3.9.10
 - `org.owasp.dependencycheck` gradle plugin: 12.1.3 -->> 12.1.7
 - `com.diffplug.spotless` gradle plugin: 7.2.1 -->> 8.0.0
 - Scala coverage:
   - scoverage: 2.0.11 -->> 2.3.0
   - Scala version for scoverage: 2.13.9 -->> 2.13.16 (i.e. `org.scoverage:scalac-scoverage-plugin_2.13.16:2.3.0` will be used)
   - `org.scoverage` gradle plugin: 8.0.3 -->> 8.1
@dejan2609
Copy link
Contributor Author

📓 Note: org.owasp.dependencycheck plugin version 12.1.7 has been released: https://github.com/dependency-check/DependencyCheck/blob/v12.1.7/CHANGELOG.md

I'll rebase this PR.

@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from ca4ec09 to 8a8b680 Compare October 13, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees

No one assigned

Labels

build Gradle build or GitHub Actions ci-approved dependencies Pull requests that update a dependency file small Small PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dejan2609 @chia7712