MINOR: simplify last known elr update #20629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrao
reviewed
Oct 2, 2025
There was a problem hiding this comment.
@CalvinConfluent : Thanks for the PR. The code LGTM. Waiting for the CI to complete.
chia7712
approved these changes
Oct 4, 2025
| if (!useLastKnownLeaderInBalancedRecovery || !eligibleLeaderReplicasEnabled) return; | ||
| if (record.isr() != null && record.isr().isEmpty() && (partition.lastKnownElr.length != 1 || | ||
| partition.lastKnownElr[0] != partition.leader)) { | ||
| if (record.leader() == NO_LEADER && (partition.lastKnownElr.length == 0)) { |
There was a problem hiding this comment.
Perhaps we could remove the redundant (). for example: (record.leader() == NO_LEADER && partition.lastKnownElr.length == 0)
There was a problem hiding this comment.
@chia7712 Thanks. Updated.
|
will merge it tomorrow if @junrao has no further reviews |
junrao
approved these changes
Oct 6, 2025
CalvinConfluent
added a commit
to CalvinConfluent/kafka
that referenced
this pull request
Oct 7, 2025
Simplify the last known elr update logic. This way can make a more robust logic. Reviewers: Jun Rao <[email protected]>, Chia-Ping Tsai <[email protected]>
chia7712
pushed a commit
that referenced
this pull request
Oct 8, 2025
Backport #20629 to 4.1 branch Simplify the last known elr update logic. This way can make a more robust logic. Reviewers: Jun Rao <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the last known elr update logic. This way can make a more
robust logic.
Reviewers: Jun Rao [email protected], Chia-Ping Tsai
[email protected]