Skip to content

MINOR: Adjust the timing for creating connect config #20612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 6, 2025
+4 −3
Merged

MINOR: Adjust the timing for creating connect config #20612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd4966f
MINOR: Adjust the timing for creating connect config
majialoong Sep 29, 2025
650583c
Additional adjust to MirrorMaker
majialoong Sep 30, 2025
87fd1b1
Adjust the warning log and add non-empty check
majialoong Sep 30, 2025
f59ac21
Restore code style
majialoong Sep 30, 2025
38372c2
Remove the modify related to ConnectPluginPath
majialoong Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,13 +233,13 @@ private void checkHerder(SourceAndTarget sourceAndTarget) {
private void addHerder(SourceAndTarget sourceAndTarget) {
log.info("creating herder for {}", sourceAndTarget.toString());
Map<String, String> workerProps = config.workerConfig(sourceAndTarget);
DistributedConfig distributedConfig = new DistributedConfig(workerProps);
String encodedSource = encodePath(sourceAndTarget.source());
String encodedTarget = encodePath(sourceAndTarget.target());
List<String> restNamespace = List.of(encodedSource, encodedTarget);
String workerId = generateWorkerId(sourceAndTarget);
Plugins plugins = new Plugins(workerProps);
plugins.compareAndSwapWithDelegatingLoader();
DistributedConfig distributedConfig = new DistributedConfig(workerProps);
String kafkaClusterId = distributedConfig.kafkaClusterId();
String clientIdBase = ConnectUtils.clientIdBase(distributedConfig);
// Create the admin client to be shared by all backing stores for this herder
Expand Down
5 changes: 3 additions & 2 deletions connect/runtime/src/main/java/org/apache/kafka/connect/cli/AbstractConnectCli.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,15 @@ public Connect<H> startConnect(Map<String, String> workerProps) {
log.info("Kafka Connect worker initializing ...");
long initStart = time.hiResClockMs();

T config = createConfig(workerProps);
log.debug("Kafka cluster ID: {}", config.kafkaClusterId());

WorkerInfo initInfo = new WorkerInfo();
initInfo.logAll();

log.info("Scanning for plugin classes. This might take a moment ...");
Plugins plugins = new Plugins(workerProps);
plugins.compareAndSwapWithDelegatingLoader();
T config = createConfig(workerProps);
log.debug("Kafka cluster ID: {}", config.kafkaClusterId());

RestClient restClient = new RestClient(config);

Expand Down
Loading