KAFKA-19591 solving issues with gradlew content: an old template version was being referenced
#20327
Conversation
github-actions
bot
added
triage
|
Note: this PR is related to Gradle upgrade from 8 to 9: #19513 (they can be combined into one, but I prefer to keep them separated). |
dejan2609
changed the title
gradlew content: an old template version (i.e. file unixStartScript.txt was being referenced)gradlew content: an old template version (i.e. file unixStartScript.txt) was being referenced
|
Note: please pardon me for force-pushing (I had to fix commit message typo error). |
|
One check fails (due to PR title being too long); will fix that. |
dejan2609
changed the title
gradlew content: an old template version (i.e. file unixStartScript.txt) was being referencedgradlew content: an old template version was being referenced
|
FYI @apoorvmittal10: this is ready for review. On a side note: Github Actions bot is doing some weird stuff with formatting (and hence description above looks kind of odd). |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
|
Note: |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
There was a problem hiding this comment.
Mental note to myself: wrapper.gradle version check def fullVersion = project.gradleVersion.count(".") == 1 ? "${project.gradleVersion}.0" : versions.gradle should be removed for Gradle versions >= 9, see links below for more details (and compare versions 8 and 9):
- Gradle version 8:
- git tag: https://github.com/gradle/gradle/releases/tag/v8.0.0
- release notes: https://docs.gradle.org/8.0/release-notes.html
- upgrade instructions:
./gradlew wrapper --gradle-version=8.0 -
- Gradle version 9:
- git tag :https://github.com/gradle/gradle/releases/tag/v9.0.0
- release notes: https://docs.gradle.org/9.0.0/release-notes.html
- upgrade instructions:
./gradlew wrapper --gradle-version=9.0.0 && ./gradlew wrapper -
…rsion (i.e. file `unixStartScript.txt`) was being referenced
|
I will have to rebase/force-push in order to sync two PR's (this one and Gradle upgrade 8 -> 9, see above for more details). |
|
@apoorvmittal10 you are free to review this PR (but it also makes sense to wait for me to bundle all changes for another PR - thing is that these changes are prerequisite for a Gradle version upgrade ). |
…); build logic changes will be pushed separately details: - gradle: 8.14.1 -->> 9.0.0 - https://github.com/gradle/gradle/releases/tag/v9.0.0 - https://gradle.org/whats-new/gradle-9 - https://docs.gradle.org/9.0.0/userguide/upgrading_major_version_9.html#changes_major_9 - shadow plugin: 8.3.6 -->> 9.0.2 - https://github.com/GradleUp/shadow/releases/tag/9.0.0 - https://github.com/GradleUp/shadow/releases/tag/9.0.1 - https://github.com/GradleUp/shadow/releases/tag/9.0.2 refactoring: - applies for Gradle >= 9: no need to check number of dots in Gradle versions anymore (and to add trailing zero if there is just one dot); see here for more details -->> apache#20327 (review) - redundant 'gradleVersion' ext property is removed (in favor of 'versions.gradle' usage)
|
Note: this PR will be closed, but code is moved and can be reviewed in a related PR here ⬇️ |
2 participants
Corresponding JIRA ticket:
Related PR:
Intro:
unixStartScript.txt(that servers as a template for agradlew) path/module was changed in Gradle version 8.8.0Problem description (for all details see JIRA ticket above):
8.14.1
but thing is that
gradlewis referencing Gradle 8.7.0 templatefile
unixStartScript.txtgradlewis missing all recent changes for a templatefile
unixStartScript.txt(i.e. all the changes that were made aftertemplate file was moved:
https://github.com/gradle/gradle/commits/v8.14.1/platforms/jvm/plugins-application/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt)
Loosely related Gradle Github issue: