-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Kafka 16801 FIx Streams upgrade :test target doesn't find any junit tests #20260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A label of 'needs-attention' was automatically added to this PR in order to raise the |
|
||
final KStreamBuilder builder = new KStreamBuilder(); | ||
final KStream dataStream = builder.stream("data"); | ||
final KStream<String, String> dataStream = builder.stream("data"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we maybe do this cleanup in a separate PR?
* limitations under the License. | ||
*/ | ||
package org.apache.kafka.streams.tests; | ||
package org.apache.kafka.streams; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we need to change the package name, to avoid conflicts with the "main" StreamsUpgradeTest.java
?
Could this cause issue when running the corresponding upgrade system test? We hardcode the same name across all version (including trunk
) https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/streams.py#L601
This will all be quite tricky to clean up, as older jar we currently load, will provide the old name...
Seems this issue is getting resolved via 6295c8a Should we close this PR, or wait until#19513 got merged? |
|
As per the discussion, the approach 4 movement from the test directories to main is implemented.
Ticket Link :- https://issues.apache.org/jira/browse/KAFKA-16801