Skip to content

Conversation

abhi-ksolves
Copy link
Contributor

As per the discussion, the approach 4 movement from the test directories to main is implemented.

Ticket Link :- https://issues.apache.org/jira/browse/KAFKA-16801

@github-actions github-actions bot added triage PRs from the community streams build Gradle build or GitHub Actions labels Jul 30, 2025
Copy link

github-actions bot commented Aug 7, 2025

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.


final KStreamBuilder builder = new KStreamBuilder();
final KStream dataStream = builder.stream("data");
final KStream<String, String> dataStream = builder.stream("data");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe do this cleanup in a separate PR?

* limitations under the License.
*/
package org.apache.kafka.streams.tests;
package org.apache.kafka.streams;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we need to change the package name, to avoid conflicts with the "main" StreamsUpgradeTest.java ?

Could this cause issue when running the corresponding upgrade system test? We hardcode the same name across all version (including trunk) https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/streams.py#L601

This will all be quite tricky to clean up, as older jar we currently load, will provide the old name...

@github-actions github-actions bot removed needs-attention triage PRs from the community labels Aug 28, 2025
@mjsax
Copy link
Member

mjsax commented Aug 28, 2025

Seems this issue is getting resolved via 6295c8a

Should we close this PR, or wait until#19513 got merged?

@chia7712
Copy link
Member

chia7712 commented Oct 7, 2025

chia7712@fedora:~/project/kafka$ ./gradlew cleanTest streams:upgrade-system-tests-37:test

> Configure project :
Starting build with version 4.2.0-SNAPSHOT (commit id c6bbbbe2) using Gradle 9.1.0, Java 21 and Scala 2.13.16
Build properties: ignoreFailures=false, maxParallelForks=24, maxScalacThreads=8, maxTestRetries=0

[Incubating] Problems report is available at: file:///home/chia7712/project/kafka/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 10.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/9.1.0/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 10s
71 actionable tasks: 6 executed, 65 up-to-date
Consider enabling configuration cache to speed up this build: https://docs.gradle.org/9.1.0/userguide/configuration_cache_enabling.html

streams:upgrade-system-tests-37:test works well after merging #19513, so I'm going to close this PR. Please feel free to reopen it if I misunderstand anything.

@chia7712 chia7712 closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Gradle build or GitHub Actions streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants