KAFKA-19315: Move ControllerMutationQuotaManager to server module #19807
+1,623
−1,160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
… mock issue in KafkaApisTest
chia7712
reviewed
May 26, 2025
server/src/main/java/org/apache/kafka/server/UnboundedControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/AbstractControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/PermissiveControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/PermissiveControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientSensors.java
Outdated
Show resolved
Hide resolved
YutaLin
changed the title
m1a2st
reviewed
May 27, 2025
server/src/main/java/org/apache/kafka/server/StrictControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
core/src/main/scala/kafka/server/metadata/ClientQuotaMetadataManager.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/ClientRequestQuotaManagerTest.scala
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
Outdated
Show resolved
Hide resolved
frankvicky
reviewed
May 28, 2025
m1a2st
reviewed
May 28, 2025
server/src/main/java/org/apache/kafka/server/ControllerMutationQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/AbstractControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientSensors.java
Outdated
Show resolved
Hide resolved
|
We will continue tracking the failing test PlaintextConsumerCommitTest > testCommitAsyncCompletedBeforeConsumerCloses [1] Type=Raft-Isolated, which is recorded in https://issues.apache.org/jira/browse/KAFKA-19352. |
chia7712
reviewed
May 29, 2025
| protected final Metrics metrics; | ||
| private final QuotaType quotaType; | ||
| protected final Time time; | ||
| private final Optional<Plugin<ClientQuotaCallback>> clientQuotaCallbackPlugin; |
There was a problem hiding this comment.
we don't need to keep it as member of ClientQuotaManager
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate ControllerMutationQuotaManager to Java implementation and move
to server module, including ClientQuotaManager and associated files.
Reviewers: PoAn Yang [email protected],
Ken Huang [email protected], TengYao
Chi [email protected], Chia-Ping
Tsai [email protected]