-
Notifications
You must be signed in to change notification settings - Fork 14.5k
KAFKA-19315: Move ControllerMutationQuotaManager to server module #19807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
… mock issue in KafkaApisTest
server/src/main/java/org/apache/kafka/server/UnboundedControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/AbstractControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/PermissiveControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/PermissiveControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientSensors.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @YutaLin for this patch, left some comments
server/src/main/java/org/apache/kafka/server/StrictControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
core/src/main/scala/kafka/server/metadata/ClientQuotaMetadataManager.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/ClientRequestQuotaManagerTest.scala
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YutaLin thanks for this patch. a couple of comments remain
server/src/main/java/org/apache/kafka/server/PermissiveControllerMutationQuota.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ControllerMutationQuotaManager.java
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ControllerMutationQuotaManager.java
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ControllerMutationQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ClientSensors.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/ControllerMutationQuotaManager.java
Outdated
Show resolved
Hide resolved
userEntity = userEntity, | ||
clientEntity = clientEntity, | ||
quota = quotaValue | ||
userEntity.toJava, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe transferToClientQuotaEntity
could return java Optional
.
Migrate ControllerMutationQuotaManager to Java implementation and move
to server module, including ClientQuotaManager and associated files.
Reviewers: PoAn Yang [email protected],
Ken Huang [email protected], TengYao
Chi [email protected], Chia-Ping
Tsai [email protected]