Skip to content

KAFKA-19315: Move ControllerMutationQuotaManager to server module #19807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 62 commits into
base: trunk
Choose a base branch
from

Conversation

YutaLin
Copy link
Contributor

@YutaLin YutaLin commented May 25, 2025

Migrate ControllerMutationQuotaManager to Java implementation and move
to server module, including ClientQuotaManager and associated files.

Reviewers: PoAn Yang [email protected],
Ken Huang [email protected], TengYao
Chi [email protected], Chia-Ping
Tsai [email protected]

@github-actions github-actions bot added triage PRs from the community core Kafka Broker performance labels May 25, 2025
YutaLin added 6 commits May 25, 2025 10:46
@YutaLin YutaLin changed the title KAFK1-19315: Move ControllerMutationQuotaManager to server module KAFKA-19315: Move ControllerMutationQuotaManager to server module May 26, 2025
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YutaLin for this patch, left some comments

YutaLin added 5 commits May 30, 2025 01:34
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YutaLin thanks for this patch. a couple of comments remain

@YutaLin YutaLin closed this Jun 12, 2025
@YutaLin YutaLin deleted the KAFKA-19315 branch June 12, 2025 22:14
@YutaLin YutaLin restored the KAFKA-19315 branch June 12, 2025 22:14
@YutaLin YutaLin reopened this Jun 13, 2025
@github-actions github-actions bot added triage PRs from the community and removed triage PRs from the community labels Jun 13, 2025
userEntity = userEntity,
clientEntity = clientEntity,
quota = quotaValue
userEntity.toJava,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe transferToClientQuotaEntity could return java Optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants