MINOR: Cleanup Core Module- Scala Modules (4/n) #19805
Merged
+169
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
frankvicky
reviewed
May 29, 2025
core/src/test/scala/unit/kafka/network/RequestChannelTest.scala
Outdated
Show resolved
Hide resolved
| @@ -567,7 +567,7 @@ class AuthorizerTest extends QuorumTestHarness with BaseAuthorizerTest { | |||
| val acl3 = new AclBinding(resource2, new AccessControlEntry(principal.toString, WILDCARD_HOST, DESCRIBE, ALLOW)) | |||
| val acl4 = new AclBinding(prefixedResource, new AccessControlEntry(wildcardPrincipal.toString, WILDCARD_HOST, READ, ALLOW)) | |||
|
|
|||
| authorizer1.createAcls(requestContext, List(acl1, acl2, acl3, acl4).asJava) | |||
| authorizer1.createAcls(requestContext, util.List.of(acl1, acl2, acl3, acl4)) | |||
| assertEquals(Set(acl1, acl2, acl3, acl4), authorizer1.acls(AclBindingFilter.ANY).asScala.toSet) | |||
There was a problem hiding this comment.
Could we change it to java.util.Set?
There was a problem hiding this comment.
Moving it to Set comes with one major issue -> The ordering.
Since its a assertEquals, if the ordering is not preserved, the test will turn flaky. And I somehow am not convinced to add a load amount of lines to use HashSet.
|
Hey @frankvicky |
|
Gentle reminder @frankvicky |
frankvicky
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Kafka Brokers support Java 17, this PR makes some changes in
core module. The changes in this PR are limited to only some Scala files
in the Core module's tests. The changes mostly include:
Arrays.asList() are replaced with List.of()
with Map.of()
To be clear, the directories being targeted in this PR from unit.kafka
module:
Reviewers: TengYao Chi [email protected]