MINOR: Cleanup Core Module- Scala Modules (3/n) #19804
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
Thanks @sjhajharia for this patch, please check the fail tests |
frankvicky
reviewed
May 29, 2025
There was a problem hiding this comment.
@sjhajharia: Thanks for the clean up.
I have a few comments.
core/src/test/scala/unit/kafka/cluster/AssignmentStateTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/coordinator/group/CoordinatorPartitionWriterTest.scala
Outdated
Show resolved
Hide resolved
...rc/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorConcurrencyTest.scala
Outdated
Show resolved
Hide resolved
| @@ -364,7 +364,7 @@ abstract class KafkaServerTestHarness extends QuorumTestHarness { | |||
| def changeClientIdConfig(sanitizedClientId: String, configs: Properties): Unit = { | |||
| Using.resource(createAdminClient(brokers, listenerName)) { | |||
| admin => { | |||
| admin.alterClientQuotas(Collections.singleton( | |||
| admin.alterClientQuotas(util.Set.of( | |||
| new ClientQuotaAlteration( | |||
| new ClientQuotaEntity(Map(ClientQuotaEntity.CLIENT_ID -> (if (sanitizedClientId == "<default>") null else sanitizedClientId)).asJava), | |||
There was a problem hiding this comment.
Could it be java.util.Map.of ?
There was a problem hiding this comment.
No. We can't use that here because of the if block. In case of "' it ends up with null with Map.of wouldn't allow.
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
Outdated
Show resolved
Hide resolved
|
Thanks @frankvicky for the review. I have addressed all the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Kafka Brokers support Java 17, this PR makes some changes in
core module. The changes in this PR are limited to only some Scala files
in the Core module's tests. The changes mostly include:
To be clear, the directories being targeted in this PR from unit.kafka module: